This repository has been archived by the owner on May 30, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's from gentoo commit 3036d691f0b4a77804ba48d90079c766c4befbe8.
It's from gentoo commit 5cf776af229d8f55d1daf955e14d2280a1c61429.
It's from gentoo commit f4c61178c08ab3263d177d0099d0349174bb7595.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit c0620976bef21eea100da13845fb29073f590024.
It's from gentoo commit 0dc151e4853d1b1fd1cc2433d4b0a12df9873692.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit f28899642a1158c227faacf2c0a0d1bc8132598c.
It's from gentoo commit c53768f692d67dde255e29f9783ca68a09c6e859.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 621421fbf693bd16dbcdd414d158f693118a56b1.
It's from gentoo commit 36fbb917d064efd21b2b077a22786ce932a2ccba.
It's from gentoo commit b28853e0d461aa9fa6edb7b986a1926aa2fed048.
It's from gentoo commit 2c07969041ff2f3f2a4f81b2db040fce315d869d.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit d9d94c1c92f59eff1a31a70cf37828052ae1ce33.
It's from gentoo commit a07107453890b58dab9b02e0b97f0b0367dc248a.
It's from gentoo commit 659259e31f11f84a40be6b3806e9bfc059be45b4.
It's from gentoo commit a0d230ff73c43898241f119990785b5fec22cda3.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 433e5aad289b25310872182c0ac4240249e98abf.
It's from gentoo commit 529604d0f0535af177d87e698390ec7dab0cbfe1.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 38b155fa1bf907617067c98eb4ba3a5d0790eb1a.
It's from gentoo commit 1f5bb14da7d063dc54370cf822d77ac4e3ced6c6.
It's from gentoo commit 09f225875fab3377ecd791fc846af43fda03ad3e.
It's from gentoo commit 4672a23c9645d2faba042607c45c7d42165aa4a4.
It's from gentoo commit 9b432cebbacb1f38289f5cf2c91853de8a621e0c.
It's from gentoo commit 838e3fbb193df477c295b3bd9f812a4e7cc9b367.
It's from gentoo commit f911b8e2cfea1d111126e835014956941d62cd60.
It's from gentoo commit 83d4dfae7ed465fa607a4aa60041d8511f384751.
It's from gentoo commit 31e437d5c46c16b4f86e255561b41dba9dbfba04.
It's from gentoo commit 2ad9100728886b7a73ed2eba0710e3ab29622f52.
It's from gentoo commit cbe262b6c9a662b80b259562aa5949623ab9247a.
It's from gentoo commit 347c196669c9272cbc67836c9ddb8ccefa338c18.
It's from gentoo commit 689d5f0486ed2a19b3cd5851283013cb5576d1fa.
It's from gentoo commit 70893149093c6dcadc3520104de552a239600197.
It's from gentoo commit 8d037b76b199e71a1d40db501e67b7aeac87fad8.
It's from gentoo commit 1c772ee12dd757251168e43cccc4babc5661212c.
It's from gentoo commit 9fc5b58347412089c0cb1e842c265c2176c443e7. It's a dependency of net-analyzer/tcpdump.
It's from gentoo commit 9979863522faf1d43e3e23b38b9d42854f1a4a55. It's a dependency of net-analyzer/tcpdump.
It was my mistake during the review to allow adding a package that is much newer than the other SELinux packages we currently have. And for some reason I started getting build failures when updating packages from 2020: !!! All ebuilds that could satisfy ">=sec-policy/selinux-base-policy-2.20210908-r1" for /build/amd64-usr/ have been masked. !!! One of the following masked packages is required to complete your request: - sec-policy/selinux-base-policy-9999::coreos (masked by: missing keyword) (dependency required by "sec-policy/selinux-sssd-2.20210908-r1::portage-stable" [ebuild]) (dependency required by "sys-auth/sssd-2.3.1-r4::coreos[selinux]" [ebuild]) (dependency required by "app-admin/sudo-1.9.5_p2::coreos[sssd]" [ebuild]) (dependency required by "coreos-base/coreos-0.0.1-r302::coreos" [ebuild]) (dependency required by "coreos-base/coreos-dev-0.1.0-r81::coreos" [ebuild]) (dependency required by "coreos-devel/board-packages-0.0.1-r9::coreos" [ebuild]) (dependency required by "coreos-devel/board-packages" [argument]) It's from gentoo commit 1f7a3661f47b4da14ac3ad8c85f54f6b144104e4.
It's from gentoo commit a3da198dcd29061496e00d4f8473d8e9f4e32826. It's a dependency of dev-libs/libbsd.
It's from gentoo commit deb1c3a3bbcc78c03b874243f982d585f14ca5aa.
This was referenced Mar 31, 2022
CI passed, but still waiting for #318 to get in first. |
jepio
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; I tend to mostly look at eclass changes in these PRs, and the list of packages updated to see if something jumps out at me.
Yeah, I need to think how to shortly describe the changes in the eclass for the next time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged together with flatcar-archive/coreos-overlay#1783.
Blocked on selinux-sssd downgrade - #318.
CI: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/5298/cldsv/
To ease the review, here's a short summary of changes in the PR: