Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Profile cleanups for package updates, 2020 edition #1783

Merged
merged 10 commits into from
Apr 4, 2022

Conversation

krnowak
Copy link
Contributor

@krnowak krnowak commented Mar 31, 2022

Should be merged together with flatcar-archive/portage-stable#320.

Please see the PR in portage-stable for more info.

CI: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/5298/cldsv/

krnowak added 9 commits March 30, 2022 20:03
The updated package is stable for both amd64 and arm64.
The updated package is stable for both amd64 and arm64.
The updated package is stable for both amd64 and arm64.
The updated package is stable for both amd64 and arm64.
It became enabled by default after an update, so revert that change in
our profiles. It was enabled upstream, because it was needed by
dev-qt/qtcore, which we don't have.
They became enabled by default after an update. We didn't need them
before, we don't need them now. Also, enabling smi pulls in
net-libs/libsmi that does not have a keyword for arm64 even.
The reasoning is written in the config file. But at the same time drop
the outdated stuff - there is no such flag like --without-ecdsa any
more.
@krnowak krnowak force-pushed the krnowak/pkg-updates-2020 branch from c96f0c8 to a65300c Compare March 31, 2022 14:07
@krnowak
Copy link
Contributor Author

krnowak commented Apr 1, 2022

CI passed, but still waiting for flatcar-archive/portage-stable#318 to get in first.

@krnowak krnowak marked this pull request as ready for review April 1, 2022 09:39
@krnowak krnowak requested a review from a team April 1, 2022 09:39
# it. We also know that constructor and destructor attributes are
# supported - they are available since at least gcc 3.4.

EXTRA_ECONF+=" ax_cv_have_func_attribute_constructor=yes"
Copy link
Contributor

@tormath1 tormath1 Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would almost be in favor of moving these options to the ebuild configuration step itself and move the ebuild to ::coreos-overlay to avoid spreading the configuration across various places...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that when I will focus more on the coreos-overlay packages, we will get to the point where we need to decide whether it is more important to keep the packages in portage-stable/gentoo at the expense of unified configuration, or to move them to coreos-overlay and modify them to our needs, but at a price of more maintainership effort needed.

For now, I'd say that I'd favor the former.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, bind-tools got a better check in newer versions, but gentoo is still packaging 9.16.x, instead of 9.18.x.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the lesser evil and allows us to consume unchanged upstream ebuilds in portage-stable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll try to make a patch for gentoo package that updates some m4 file, so we can eventually drop this file.

Copy link
Contributor

@jepio jepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# it. We also know that constructor and destructor attributes are
# supported - they are available since at least gcc 3.4.

EXTRA_ECONF+=" ax_cv_have_func_attribute_constructor=yes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the lesser evil and allows us to consume unchanged upstream ebuilds in portage-stable.

@krnowak krnowak merged commit 04bc4b5 into main Apr 4, 2022
@krnowak krnowak deleted the krnowak/pkg-updates-2020 branch April 4, 2022 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants