-
Notifications
You must be signed in to change notification settings - Fork 36
Profile cleanups for package updates, 2020 edition #1783
Conversation
The updated package is stable for both amd64 and arm64.
The updated package is stable for both amd64 and arm64.
The updated package is stable for both amd64 and arm64.
The updated package is stable for both amd64 and arm64.
It became enabled by default after an update, so revert that change in our profiles. It was enabled upstream, because it was needed by dev-qt/qtcore, which we don't have.
They became enabled by default after an update. We didn't need them before, we don't need them now. Also, enabling smi pulls in net-libs/libsmi that does not have a keyword for arm64 even.
The reasoning is written in the config file. But at the same time drop the outdated stuff - there is no such flag like --without-ecdsa any more.
c96f0c8
to
a65300c
Compare
CI passed, but still waiting for flatcar-archive/portage-stable#318 to get in first. |
# it. We also know that constructor and destructor attributes are | ||
# supported - they are available since at least gcc 3.4. | ||
|
||
EXTRA_ECONF+=" ax_cv_have_func_attribute_constructor=yes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would almost be in favor of moving these options to the ebuild configuration step itself and move the ebuild to ::coreos-overlay
to avoid spreading the configuration across various places...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that when I will focus more on the coreos-overlay packages, we will get to the point where we need to decide whether it is more important to keep the packages in portage-stable/gentoo at the expense of unified configuration, or to move them to coreos-overlay and modify them to our needs, but at a price of more maintainership effort needed.
For now, I'd say that I'd favor the former.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, bind-tools got a better check in newer versions, but gentoo is still packaging 9.16.x, instead of 9.18.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the lesser evil and allows us to consume unchanged upstream ebuilds in portage-stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll try to make a patch for gentoo package that updates some m4 file, so we can eventually drop this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# it. We also know that constructor and destructor attributes are | ||
# supported - they are available since at least gcc 3.4. | ||
|
||
EXTRA_ECONF+=" ax_cv_have_func_attribute_constructor=yes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the lesser evil and allows us to consume unchanged upstream ebuilds in portage-stable.
Should be merged together with flatcar-archive/portage-stable#320.
Please see the PR in portage-stable for more info.
CI: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/5298/cldsv/