Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/vm, params: ensure order of forks, prevent overflow #20

Merged
merged 1 commit into from
Mar 14, 2024
Merged

core/vm, params: ensure order of forks, prevent overflow #20

merged 1 commit into from
Mar 14, 2024

Conversation

0x416e746f6e
Copy link

this PR ports upstream ethereum#29023:

This PR fixes an overflow which can could happen if inconsistent blockchain rules were configured. Additionally, it tries to prevent such inconsistencies from occurring by making sure that merge cannot be enabled unless previous fork(s) are also enabled.

Without this PR, it is possible to set the overrides on an eth_call over RPC and trigger a method-handler crash (not a full node crash).

Hat-tip to @pleasew8t for reporting this via the bounty via a very well-written submission.

@allnil allnil mentioned this pull request Mar 7, 2024
Merged
@ferranbt ferranbt merged commit 389d537 into main Mar 14, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferranbt ferranbt ferranbt approved these changes

@Ruteri Ruteri Awaiting requested review from Ruteri Ruteri is a code owner

@metachris metachris Awaiting requested review from metachris metachris is a code owner

@dmarzzz dmarzzz Awaiting requested review from dmarzzz dmarzzz is a code owner

@lthibault lthibault Awaiting requested review from lthibault

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x416e746f6e @ferranbt