core/vm, params: ensure order of forks, prevent overflow #29023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
params/config.go
Outdated
| @@ -910,6 +910,11 @@ func (c *ChainConfig) Rules(num *big.Int, isMerge bool, timestamp uint64) Rules | |||
| if chainID == nil { | |||
| chainID = new(big.Int) | |||
| } | |||
| if c.IsShanghai(num, timestamp) { | |||
There was a problem hiding this comment.
I think it's pretty weird. It can happen that:
London, Merge, Shanghai forks are all configured, but merge is not activated (ttd is not reached). In this case even the London is activated and pre-configured shanghai timestamp is reached, Shanghai shouldn't be enabled.
holiman
commented
Feb 19, 2024
holiman
force-pushed
the
fix_rpc_crash
branch
from
23773e5
to
64d32e5
Compare
Tristan-Wilson
pushed a commit
to OffchainLabs/go-ethereum
that referenced
this pull request
Apr 3, 2024
This PR fixes an overflow which can could happen if inconsistent blockchain rules were configured. Additionally, it tries to prevent such inconsistencies from occurring by making sure that merge cannot be enabled unless previous fork(s) are also enabled. (cherry picked from commit ac0ff04) aka ethereum/go-ethereum#29023
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Apr 29, 2024
core/vm, params: ensure order of forks, prevent overflow (ethereum#29023)
billettc
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
May 13, 2024
…ereum#29023)" This reverts commit 1c12cf9.
jorgemmsilva
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an overflow which can could happen if inconsistent blockchain rules were configured. Additionally, it tries to prevent such inconsistencies from occurring by making sure that merge cannot be enabled unless previous fork(s) are also enabled.
Without this PR, it is possible to set the overrides on an
eth_callover RPC and trigger a method-handler crash (not a full node crash).Hat-tip to @pleasew8t for reporting this via the bounty via a very well-written submission.