Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mainnet by default #381

Merged
merged 1 commit into from
Nov 3, 2022
Merged

use mainnet by default #381

merged 1 commit into from
Nov 3, 2022

Conversation

metachris
Copy link
Collaborator

πŸ“ Summary

Use -mainnet by default


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

Codecov Report

Merging #381 (4de8914) into main (1a11894) will increase coverage by 1.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   66.02%   67.15%   +1.12%     
==========================================
  Files           7        7              
  Lines         889      889              
==========================================
+ Hits          587      597      +10     
+ Misses        265      258       -7     
+ Partials       37       34       -3     
Flag Coverage Ξ”
unittests 67.15% <ΓΈ> (+1.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
cli/main.go 13.51% <ΓΈ> (ΓΈ)
server/service.go 80.23% <0.00%> (+2.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

terencechain
terencechain previously approved these changes Oct 21, 2022
Copy link
Collaborator

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@metachris
Copy link
Collaborator Author

added a fix, otherwise it wouldn't allow any other network :)

avalonche
avalonche previously approved these changes Oct 24, 2022
@metachris metachris merged commit f146349 into main Nov 3, 2022
@metachris metachris deleted the mainnet-default branch November 3, 2022 20:33
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants