Upcoming mev-boost release: v1.4.0 #377

metachris · 2022-10-19T09:42:22Z

A number of improvements have accumulated since the last release (v1.3.2 on September 22, 2022), and it's time to think about the next release v1.4.0!

These are the already merged changes since the last release:

v1.3.2...main

Would love to hear any comments, concerns, thoughts!

The process would be:

merge any remaining PRs that we want in the release
test for a few some time on testnets (Goerli, Sepolia) in partnership with node operators
release

The text was updated successfully, but these errors were encountered:

metachris · 2022-10-20T12:05:40Z

The remaining PRs have been completed and merged.

Major improvements:

Min bid #274 (allow setting a minimum required bid value)
Send auction transcript to relay monitor #297
Add new relay/relay-monitor flags that can be used multiple times #351
use mainnet by default #381
log version always, fix loglevel config #362 (log version by default on every line, to ease debugging. can be disabled with -log-no-version and env var DISABLE_LOG_VERSION)
update to go 1.19 #397

Minor, but noteworthy:

Next steps:

Creating a release candidate
Testing in testnets

metachris · 2022-10-21T08:00:22Z

Prepared release candidate 1: mev-boost v1.4.0-rc1

go install github.com/flashbots/[email protected]
Docker image: flashbots/mev-boost:1.4.0-rc1 (6.3 MB)
Code: https://github.com/flashbots/mev-boost/releases/tag/v1.4.0-rc1
Full changelog: v1.3.2...v1.4.0-rc1

metachris · 2022-10-21T08:12:57Z

Help output with cli args:

$ docker run flashbots/mev-boost:1.4.0-rc1 -help
Usage of /app/mev-boost:
  -addr string
        listen-address for mev-boost server (default "localhost:18550")
  -debug
        shorthand for '-loglevel debug'
  -genesis-fork-version string
        use a custom genesis fork version
  -goerli
        use Goerli
  -json
        log in JSON format instead of text
  -log-no-version
        disables adding the version to every log entry
  -log-service string
        add a 'service=...' tag to all log messages
  -loglevel string
        minimum loglevel: trace, debug, info, warn/warning, error, fatal, panic (default "info")
  -mainnet
        use Mainnet
  -min-bid float
        minimum bid to accept from a relay [eth]
  -relay value
        a single relay, can be specified multiple times
  -relay-check
        check relay status on startup and on the status API call
  -relay-monitor value
        a single relay monitor, can be specified multiple times
  -relay-monitors string
        relay monitor urls - single entry or comma-separated list (scheme://host)
  -relays string
        relay urls - single entry or comma-separated list (scheme://pubkey@host)
  -request-timeout-getheader int
        timeout for getHeader requests to the relay [ms] (default 950)
  -request-timeout-getpayload int
        timeout for getPayload requests to the relay [ms] (default 4000)
  -request-timeout-regval int
        timeout for registerValidator requests [ms] (default 3000)
  -sepolia
        use Sepolia
  -version
        only print version

metachris · 2022-10-21T13:32:42Z

Found an issue in requesting gzip encoded responses. Fix: #382 (v1.4.0-rc3 Docker image)

metachris · 2022-10-22T11:07:05Z

Turns out, Go http requests add Accept-Encoding: gzip automatically (and do the decoding). And if the header is set manually then it wouldn't auto decode. See also #383

Also merged #380 with minor cleanup

Current release candidate: v1.4.0-rc4
Docker image: flashbots/mev-boost:1.4.0-rc4

nalepae · 2022-10-24T09:28:43Z

Tested rc3 during 2 days and rc4 for a few hours on Sepolia (100 keys, proposing very often).
100% block proposals using Sepolia Flashbots relay success.

(Also tested on Goerli)

metachris · 2022-10-31T06:55:37Z

This release will be out within a week or so.

The reason for being slow to roll out include (a) ongoing discussions about whether to include #297, (b) wanting to add this release to this week's CL call, and (c) me being on vacation until Thursday.

metachris · 2022-11-03T21:38:19Z

Merged two more notable PRs:

And a few minor PRs. See v1.4.0-rc4...v1.4.0-rc5

Prepared v1.4.0-rc5

last expected release candidate

https://github.com/flashbots/mev-boost/tree/v1.4.0-rc5
Compare with latest official release v1.3.2: v1.3.2...v1.4.0-rc5
Compare with last RC: v1.4.0-rc4...v1.4.0-rc5
Docker images:
- flashbots/mev-boost:1.4.0-rc5
- flashbots/mev-boost:1.4.0-rc5-portable

metachris · 2022-11-04T09:46:02Z

Should we remove the strict json decoding from the getPayload call to accomodate future consensus changes in a backwards-compatible manner? And add this to the current release?

For instance the upcoming Capella and EIP-4844 changes will modify certain payloads, which would guarantee to break in the current mev-boost version because of the strict JSON payload decoding (disallowing unknown fields). See also #392 for more details about the specific changes.

metachris · 2022-11-04T10:26:10Z

We may also want to revert #299 now, since it would incorrectly alert to have received a different block hash once the new payload fields are live.

ralexstokes · 2022-11-04T17:02:30Z

is it not better to keep the strict {en,de}coding and instead just support versioned types? -- we have to address this problem in e.g. the beacon APIs so we can just do something similar here

metachris · 2022-11-04T20:18:46Z

The strict en/decoding is only used in a single place (decoding the getPayload request body from the beacon node), where it doesn't actually serve a purpose, since the full payload is already read before (therefore it wouldn't protect from resource exhaustion).

I think it'd be better to remove the constraint in the decoding, which has no downsides but leaves more options open for the future. Fwiw, i've heard various opinions from CL devs about adding a new API version in the builder specs for each payload change vs adding it in a backwards compatible way.

jtraglia · 2022-11-04T21:16:33Z

Wouldn't there still be a problem? The SignedBlindedBeaconBlock from the BN will most likely have an additional field (like bls_to_execution_changes). The block in mev-boost wouldn't have that field, it would send the signed blinded block with a missing field to the relay, and it would then fail the signature check, right?

metachris · 2022-11-07T14:04:08Z

Yeah @jtraglia that is correct. I think we can leave the json as is for now, and it will be a mandatory mev-boost upgrade along with EL+CL anyway. Cutting a new, possibly final, release candidate now.

metachris · 2022-11-07T14:18:22Z

Created a new release candidate based on current main. Feature freeze.

v1.4.0-rc6

https://github.com/flashbots/mev-boost/tree/v1.4.0-rc6
Compare with last release v1.3.2: v1.3.2...v1.4.0-rc6
Compare with last release candidate: v1.4.0-rc5...v1.4.0-rc6
Docker images:
- flashbots/mev-boost:1.4.0-rc6
- flashbots/mev-boost:1.4.0-rc6-portable

Next steps:

Waiting for @ralexstokes to tell us whether to use his relay monitor server in the rc testing
Testing on testnets by node operators
Release later this week

metachris · 2022-11-08T09:51:20Z

ETA for publishing this release is tomorrow - Wednesday Nov. 9, 2022.

nalepae · 2022-11-09T09:24:11Z

I have some error messages:

time="2022-11-09T08:34:00Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T08:40:00Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T08:40:24Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T08:46:24Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T08:46:48Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T08:52:48Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T08:53:12Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T08:59:12Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T08:59:36Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T09:05:36Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T09:06:00Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T09:12:00Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T09:12:24Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T09:15:36Z" level=warning msg="error sending auction transcript to relay monitor" error="HTTP error response: 502 / " method=sendAuctionTranscriptToRelayMonitors url="https://sepolia.relay-monitor.pbs.dev/monitor/v1/transcript" version=v1.4.0-rc6
time="2022-11-09T09:18:24Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6
time="2022-11-09T09:18:48Z" level=warning msg="error calling registerValidator on relay monitor" error="HTTP error response: 502 / " method=sendValidatorRegistrationsToRelayMonitors numRegistrations=50 url="https://sepolia.relay-monitor.pbs.dev/eth/v1/builder/validators" version=v1.4.0-rc6

Args:

      --relay-check
      --relay-monitor=https://sepolia.relay-monitor.pbs.dev
      --relays=https://0x845bd072b7cd566f02faeb0a4033ce9399e42839ced64e8b2adcfc859ed1e8e1a5a293336a49feac6d9a5edb779be53a@builder-relay-sepolia.flashbots.net
      --sepolia

nalepae · 2022-11-09T09:25:40Z

Also:

time="2022-11-08T21:31:48Z" level=error msg="relay status error - request failed" error="Get \"https://builder-relay-sepolia.flashbots.net/eth/v1/builder/status\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)" url="https://builder-relay-sepolia.flashbots.net/eth/v1/builder/status" version=v1.4.0-rc6
time="2022-11-08T21:31:48Z" level=warning msg="error making request to relay" error="Get \"https://builder-relay-sepolia.flashbots.net/eth/v1/builder/header/1017459/0x4c775e3bcbc9dc42f6ab2b3ec5a11145de28de8388f677136693dd590d5f9953/0xb0d4231814e40e53ab4eed8333d418a6e2e4bd3910148b610dec5f91961df1ad63f4661d533137a503d809ea1ad576fa\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)" method=getHeader parentHash=0x4c775e3bcbc9dc42f6ab2b3ec5a11145de28de8388f677136693dd590d5f9953 pubkey=0xb0d4231814e40e53ab4eed8333d418a6e2e4bd3910148b610dec5f91961df1ad63f4661d533137a503d809ea1ad576fa slot=1017459 url="https://builder-relay-sepolia.flashbots.net/eth/v1/builder/header/1017459/0x4c775e3bcbc9dc42f6ab2b3ec5a11145de28de8388f677136693dd590d5f9953/0xb0d4231814e40e53ab4eed8333d418a6e2e4bd3910148b610dec5f91961df1ad63f4661d533137a503d809ea1ad576fa" version=v1.4.0-rc6

metachris · 2022-11-09T09:28:15Z

Thanks @nalepae 🙏

The first errors are the relay monitor from @ralexstokes being down currently, and are fine to disregard
The second errors are status and getHeader timeout on the Sepolia relay, which is also fine

nalepae · 2022-11-09T10:34:22Z

Ran rc6 version during ~24H
https://sepolia.beaconcha.in/slots?q=%F0%9F%A7%B1%F0%9F%94%A5+Kiln.fi+%F0%9F%94%A5%F0%9F%A7%B1

metachris · 2022-11-09T14:53:16Z

Released https://github.com/flashbots/mev-boost/releases/tag/v1.4.0

metachris added next up It's next up testing labels Oct 21, 2022

metachris mentioned this issue Nov 4, 2022

json decoding: allow unknown fields (in preparation for Capella and EIP-4844) #393

Closed

3 tasks

metachris closed this as completed Nov 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upcoming mev-boost release: v1.4.0 #377

Upcoming mev-boost release: v1.4.0 #377

metachris commented Oct 19, 2022 •

edited

Loading

metachris commented Oct 20, 2022 •

edited

Loading

metachris commented Oct 21, 2022 •

edited

Loading

metachris commented Oct 21, 2022 •

edited

Loading

metachris commented Oct 21, 2022

metachris commented Oct 22, 2022

nalepae commented Oct 24, 2022

metachris commented Oct 31, 2022

metachris commented Nov 3, 2022

metachris commented Nov 4, 2022 •

edited

Loading

metachris commented Nov 4, 2022

ralexstokes commented Nov 4, 2022 •

edited

Loading

metachris commented Nov 4, 2022 •

edited

Loading

jtraglia commented Nov 4, 2022

metachris commented Nov 7, 2022

metachris commented Nov 7, 2022 •

edited

Loading

metachris commented Nov 8, 2022

nalepae commented Nov 9, 2022

nalepae commented Nov 9, 2022

metachris commented Nov 9, 2022

nalepae commented Nov 9, 2022

metachris commented Nov 9, 2022

Upcoming mev-boost release: v1.4.0 #377

Upcoming mev-boost release: v1.4.0 #377

Comments

metachris commented Oct 19, 2022 • edited Loading

metachris commented Oct 20, 2022 • edited Loading

metachris commented Oct 21, 2022 • edited Loading

metachris commented Oct 21, 2022 • edited Loading

metachris commented Oct 21, 2022

metachris commented Oct 22, 2022

nalepae commented Oct 24, 2022

metachris commented Oct 31, 2022

metachris commented Nov 3, 2022

metachris commented Nov 4, 2022 • edited Loading

metachris commented Nov 4, 2022

ralexstokes commented Nov 4, 2022 • edited Loading

metachris commented Nov 4, 2022 • edited Loading

jtraglia commented Nov 4, 2022

metachris commented Nov 7, 2022

metachris commented Nov 7, 2022 • edited Loading

metachris commented Nov 8, 2022

nalepae commented Nov 9, 2022

nalepae commented Nov 9, 2022

metachris commented Nov 9, 2022

nalepae commented Nov 9, 2022

metachris commented Nov 9, 2022

metachris commented Oct 19, 2022 •

edited

Loading

metachris commented Oct 20, 2022 •

edited

Loading

metachris commented Oct 21, 2022 •

edited

Loading

metachris commented Oct 21, 2022 •

edited

Loading

metachris commented Nov 4, 2022 •

edited

Loading

ralexstokes commented Nov 4, 2022 •

edited

Loading

metachris commented Nov 4, 2022 •

edited

Loading

metachris commented Nov 7, 2022 •

edited

Loading