add a -log-service cli flag #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #355 +/- ##
==========================================
+ Coverage 81.44% 82.47% +1.03%
==========================================
Files 5 5
Lines 679 679
==========================================
+ Hits 553 560 +7
+ Misses 96 91 -5
+ Partials 30 28 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
avalonche
reviewed
Sep 27, 2022
| @@ -90,6 +91,9 @@ func Main() { | |||
| } | |||
| logrus.SetLevel(lvl) | |||
| } | |||
| if *logService != "" { | |||
There was a problem hiding this comment.
shouldn't the logger add service=mev-boost by default instead of explicitly adding via a flag?
There was a problem hiding this comment.
no, better to keep the default off, and only enable it if wanted by the user
avalonche
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
For production logs it's sometimes useful to add a dedicated
servicetag to distinguish services by their logs only. This PR adds a-log-serviceflag, which when given adds aservice=...tag to each and ever log message.✅ I have run these commands
make lintmake test-racego mod tidy