Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unable to use permission grid dropdowns #3065

Merged
merged 1 commit into from
Sep 5, 2021

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Sep 4, 2021

Changes proposed in this pull request:
Fixes a regression introduced in #2887, I had suggested a change here: #2887 (review)

But that ended up preventing clicking on dropdown items, making the permission grid unusable.

Screenshot

Before After
flarum lan_admin (3) flarum lan_admin (2)

Confirmed

  • Frontend changes: tested on a local Flarum installation.

@SychO9 SychO9 merged commit 1aa61f1 into master Sep 5, 2021
@SychO9 SychO9 deleted the sm/permission-grid-dropdown-regression branch September 5, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants