Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission Grid: stick the headers to handle a lot of tags #2887

Merged
merged 8 commits into from
Aug 14, 2021
Merged

Permission Grid: stick the headers to handle a lot of tags #2887

merged 8 commits into from
Aug 14, 2021

Conversation

Ornanovitch
Copy link
Contributor

@Ornanovitch Ornanovitch commented May 25, 2021

Fixes #2810
Temporary fix before flarum/issue-archive#253

Changes proposed in this pull request:

Stick thead th and tbody th: when you have a lot of tags permissions to handle, it's more consistent to be able to see the headers you're in.

Reviewers should focus on:

To be tested with a lot of Restrict by Tag 🏷️
Does it work on safari?

Screenshot

FA isn't loaded on my local dev environment, I don't know why but it has nothing to do with this PR 😸
Screenshot_2021-05-25 forum

Confirmed

  • Frontend changes: tested on a local Flarum installation.

@SychO9
Copy link
Member

SychO9 commented May 27, 2021

Hello!

Thank you for the PR, I have actually played with the idea a bit in the past, and really liked it.

We will review this soon when we pick up development again 🤗

@Ornanovitch
Copy link
Contributor Author

Take your time, all of you deserve it!

I'd be glad to start trying to improve a little Flarum with my limited skill but there is no rush at all, I'll wait for your review :)

@luceos
Copy link
Member

luceos commented Jun 21, 2021

@Ornanovitch thanks so much, this is awesome. I've assigned a couple of reviewers in the hope to push this into the next release 🤞 . The ux on the permissions page is seriously hampered with many tags or groups, so thank you for thinking along!

@luceos luceos added the javascript Pull requests that update Javascript code label Jun 21, 2021
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! a few comments

Can you add to

.PermissionGrid-child {
  td, th {
    position: relative;

a z-index: 0 as it can overlap the th when hovered.

less/admin/PermissionsPage.less Outdated Show resolved Hide resolved
less/admin/PermissionsPage.less Show resolved Hide resolved
less/admin/PermissionsPage.less Show resolved Hide resolved
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, left a nit.

Is there a reason we haven't merged this yet, or have we just not gotten around to it yet?

@@ -49,19 +50,36 @@
color: @muted-color;
}
thead th {
position: -webkit-sticky;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't suppose we can avoid vendor specific stuff here?

Copy link
Member

@SychO9 SychO9 Aug 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now we need it for some old safari browsers

https://caniuse.com/?search=sticky

@SychO9
Copy link
Member

SychO9 commented Aug 14, 2021

Is there a reason we haven't merged this yet, or have we just not gotten around to it yet?

Just needed a second approval!

@SychO9 SychO9 merged commit 634dfc6 into flarum:master Aug 14, 2021
@SychO9 SychO9 removed the javascript Pull requests that update Javascript code label Aug 15, 2021
@Ornanovitch Ornanovitch deleted the or/sticky-PermissionGrid branch August 26, 2021 11:22
SychO9 added a commit that referenced this pull request Sep 4, 2021
SychO9 added a commit that referenced this pull request Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue about bad visual if you have many tags permissions
5 participants