Fix searching titles in discussions #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
force-pushed
the
as/discussion-title-search
branch
from
2f8973d
to
e04929d
Compare
askvortsov1
force-pushed
the
as/discussion-title-search
branch
from
70044b3
to
c0ff37c
Compare
tankerkiller125
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
This has been running on https://discuss.flarum.org for about a week now with excellent results.
There has been no noticeable changes to resources used on the VPS and the search seems to be just as fast as it was without title searching.
SychO9
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This was originally attempted in #1741, but reverted in 9f6ec80 due to performance issues. From pure speculation, this should not cause such issues. From local dev environment testing (on a small dataset), that claim holds.
Implementation:
Instead of using a left join to include discussions, we add an additional subquery where we search discussions by title, union that into the posts subquery, and only then join.
Reviewers should focus on:
Confirmed
composer test).