Fixes #1738 : Search Title within discussions #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! Nice find and nice fix. I've added a regression test to prevent this from coming back. |
|
You are welcome.
Thanks a lot to you and your team for this nice project
Le jeu. 7 mars 2019 à 00:22, Franz Liedke <[email protected]> a
écrit :
… Thanks a lot! Nice find and nice fix.
I've added a regression test
<26c3bcd>
to prevent this from coming back.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1741 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AD8_DB6H_l87phbF3rR8IhOAM4Si4UTjks5vUE3CgaJpZM4ad_qZ>
.
--
Bertrand DUMAS-PILHOU
|
|
SQL being my # 1, I should of caught this myself ;-) |
|
Any changes to the search engine should undergo performance testing before they are committed (or we should somehow automate that in the tests) Unfortunately this change has a detrimental effect on performance in my rough testing - a search which previously took ~40ms now takes 3 seconds. |
|
Oh, sorry about that. |
franzliedke
added a commit
that referenced
this pull request
Oct 26, 2019
We decided it is better to have a less intelligent search (that does not match search terms in titles) for some people than a bad-performing search for everyone. We will revisit the search performance topic in the next release cycle, possibly with larger changes around indexing. Refs #1738, #1741, #1764.
luceos
pushed a commit
that referenced
this pull request
Feb 4, 2020
We decided it is better to have a less intelligent search (that does not match search terms in titles) for some people than a bad-performing search for everyone. We will revisit the search performance topic in the next release cycle, possibly with larger changes around indexing. Refs #1738, #1741, #1764.
wzdiyb
pushed a commit
to wzdiyb/core
that referenced
this pull request
Feb 16, 2020
wzdiyb
pushed a commit
to wzdiyb/core
that referenced
this pull request
Feb 16, 2020
We decided it is better to have a less intelligent search (that does not match search terms in titles) for some people than a bad-performing search for everyone. We will revisit the search performance topic in the next release cycle, possibly with larger changes around indexing. Refs flarum#1738, flarum#1741, flarum#1764.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Fixes #1738 **
Changes proposed in this pull request:
You can search in title discussion even if word does not appear in a post of this discussion
Reviewers should focus on:
Test searching toolbar with a word in discussion title