Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl to required PHP extensions #36

Closed
wants to merge 1 commit into from
Closed

Add curl to required PHP extensions #36

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 24, 2016

curl is required by tijsverkoyen/akismet during the composer installation.

curl is required by `tijsverkoyen/akismet` during the composer installation.
@franzliedke
Copy link
Contributor

Hmm, Akismet is only an extension, do we want to mark this as a core requirement, too?

If we merge this, we have to add this in https://github.com/flarum/core/blob/master/src/Install/InstallServiceProvider.php, too.

@tobyzerner
Copy link
Contributor

I don't think so, instead we should do some kind of check when enabling the Akismet extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants