Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extensions] check php requirements on install #1039

Closed
luceos opened this issue Sep 22, 2016 · 6 comments
Closed

[extensions] check php requirements on install #1039

luceos opened this issue Sep 22, 2016 · 6 comments

Comments

@luceos
Copy link
Member

luceos commented Sep 22, 2016

Related to this PR we need Flarum to check the composer.json file for platform requirements before allowing installation.

Opened this issue in favor of the PR.

@askvortsov1
Copy link
Member

This is supported by Composer as a part of composer in https://getcomposer.org/doc/01-basic-usage.md#platform-packages.

@luceos
Copy link
Member Author

luceos commented Mar 9, 2020

You're assuming people run flarum on the same host they installed it on. To prevent broken installs we could check platform requirements when enabling. That is what this is about.

I'd like to propose to push this into an epic about the changes to the installation process (including the composer alternative).

@askvortsov1
Copy link
Member

I think https://getcomposer.org/doc/07-runtime.md#platform-check might be exactly what we need!

@luceos
Copy link
Member Author

luceos commented Nov 11, 2020

@askvortsov1 I wish I had known about that platform check sooner. We should also consider adding this to php flarum info.

@askvortsov1
Copy link
Member

This is a composer 2 feature, so we couldn't really have done anything before. But anyways, this is something we could check before enabling extensions? Not 100% sure about php flarum info since that only shows enabled extensions (although, of course, that's under our control)

@luceos
Copy link
Member Author

luceos commented Nov 12, 2020

The file does an exit and I assume it is build dynamically whenever you run composer update commands. So including it anywhere outside of a cli command makes no particular sense, unless you wrap it in dirty exec calls. Including the file at the end of the InfoCommand if it exists would provide another layer of debugging to users and support staff.

Anyhow 👍

@luceos luceos closed this as completed Jan 12, 2021
@askvortsov1 askvortsov1 removed this from the 0.1 milestone Jan 12, 2021
@luceos luceos modified the milestone: 0.1 Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants