-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extensions] check php requirements on install #1039
Comments
This is supported by Composer as a part of composer in https://getcomposer.org/doc/01-basic-usage.md#platform-packages. |
You're assuming people run flarum on the same host they installed it on. To prevent broken installs we could check platform requirements when enabling. That is what this is about. I'd like to propose to push this into an epic about the changes to the installation process (including the composer alternative). |
I think https://getcomposer.org/doc/07-runtime.md#platform-check might be exactly what we need! |
@askvortsov1 I wish I had known about that platform check sooner. We should also consider adding this to |
This is a composer 2 feature, so we couldn't really have done anything before. But anyways, this is something we could check before enabling extensions? Not 100% sure about |
The file does an exit and I assume it is build dynamically whenever you run composer update commands. So including it anywhere outside of a cli command makes no particular sense, unless you wrap it in dirty exec calls. Including the file at the end of the InfoCommand if it exists would provide another layer of debugging to users and support staff. Anyhow 👍 |
Related to this PR we need Flarum to check the composer.json file for platform requirements before allowing installation.
Opened this issue in favor of the PR.
The text was updated successfully, but these errors were encountered: