set keepProcessEnv to false and re-enable react module-resolution test
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
dario-piotrowicz
requested review from
jamesopstad and
petebacondarwin
and removed request for
jamesopstad
jamesopstad
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Looks good to me. Do you mind adding some context to the description based on what we discussed in the other PR (and the Cloudflare docs)? Then @petebacondarwin can review and understand the implications. Thanks.
petebacondarwin
approved these changes
Dec 13, 2024
dario-piotrowicz
changed the title
keepProcessEnv to false and re-enable react module-resolution testkeepProcessEnv: true option and re-enable react module-resolution test
dario-piotrowicz
changed the title
keepProcessEnv: true option and re-enable react module-resolution testkeepProcessEnv to false and re-enable react module-resolution test
This reverts commit a00582b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #82
As discussed in #94
As per our docs:
in workers
process.envis an empty object, so I think it's actually ok to just usekeepProcessEnv: falsesince Vite replacesprocess.envs with empty objects, so I think that there is actually little to no difference between havingkeepProcessEnvset totrueorfalsefor usSetting if to
falsehas the benefit that Vite replacesprocess.env.NODE_ENVwhenkeepProcessEnvisfalse(discord message) fixing the issue we were encountering with thereactimportkeepProcessEnv: truecould be needed if the workerdprocess.envimplementation were to change at some point, but right nowkeepProcessEnv: falsemight be the most appropriate configuration