set keepProcessEnv to false and re-enable react module-resoluti…

…on test (#107)
flarelabs-net · Dec 16, 2024 · f605226 · f605226
1 parent 91ca74f
commit f605226
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/vite-plugin-cloudflare/src/cloudflare-environment.ts b/packages/vite-plugin-cloudflare/src/cloudflare-environment.ts
@@ -176,7 +176,7 @@ export function createCloudflareEnvironmentOptions(
 				],
 			},
 		},
-		keepProcessEnv: true,
+		keepProcessEnv: false,
 	};
 }
 

diff --git a/playground/module-resolution/__tests__/module-resolution.spec.ts b/playground/module-resolution/__tests__/module-resolution.spec.ts
@@ -76,9 +76,7 @@ describe('module resolution', async () => {
 	 *  special meaning to us.
 	 */
 	describe('third party packages resolutions', () => {
-		// TODO: we skip this test on build because a `ReferenceError: process is not defined` is thrown
-		//       (https://github.com/flarelabs-net/vite-plugin-cloudflare/issues/82)
-		test.skipIf(isBuild)('react', async () => {
+		test('react', async () => {
 			const result = await getJsonResponse('/third-party/react');
 			expect(result).toEqual({
 				'(react) reactVersionsMatch': true,
-Original file line number
+Diff line change
@@ Expand Up / @@ -176,7 +176,7 @@ export function createCloudflareEnvironmentOptions( @@
     				],
     			},
     		},
-    		keepProcessEnv: true,
+    		keepProcessEnv: false,
     	};
     }
@@ Expand Down @@