Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive old KalmanFilter code #317

Merged
merged 2 commits into from
Sep 1, 2014

Conversation

snozawa
Copy link
Contributor

@snozawa snozawa commented Aug 30, 2014

#296
で古いKalmanFilterのコードがきえていますが、古いバージョンのコードとして残しておきたいのと、
移行がおわりきれてないため選べるようにしました。

@eisoku9618 さん確認をお願いします。

@k-okada
Copy link
Contributor

k-okada commented Aug 30, 2014

Test PASSed.
Refer to this link for build results: http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080job/hrpsys-qnx/1582/

@eisoku9618
Copy link
Contributor

コメントアウトとコメントインにより,両方のフィルタが切り替えられることの動作確認をしました.

@snozawa
Copy link
Contributor Author

snozawa commented Aug 30, 2014

@fkanehiro さん、確認終わりましたので、
テスト等通りましたらmergeをしていただけますと助かります。

@snozawa
Copy link
Contributor Author

snozawa commented Sep 1, 2014

#318
の.travis.ymlの変更をいれて、再度PRし直しました。

よろしくお願いいたします。

@k-okada
Copy link
Contributor

k-okada commented Sep 1, 2014

Test PASSed.
Refer to this link for build results: http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080job/hrpsys-qnx/1591/

@k-okada
Copy link
Contributor

k-okada commented Sep 1, 2014

snozawa@06e1b48#diff-d41d8cd98f00b204e9800998ecf8427e
が入っているのはダメじゃなかな?

@snozawa snozawa force-pushed the revive_old_kf_codes branch from 06e1b48 to 1501563 Compare September 1, 2014 14:45
@snozawa
Copy link
Contributor Author

snozawa commented Sep 1, 2014

すいません、大変な勘違いをしてました。
#318 (comment)

再度作成しましたので、よろしくお願いいたします。

@k-okada
Copy link
Contributor

k-okada commented Sep 1, 2014

Test PASSed.
Refer to this link for build results: http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080job/hrpsys-qnx/1592/

@k-okada
Copy link
Contributor

k-okada commented Sep 1, 2014

thanks, looks good to me.

fkanehiro added a commit that referenced this pull request Sep 1, 2014
@fkanehiro fkanehiro merged commit 1ecaac5 into fkanehiro:master Sep 1, 2014
@snozawa snozawa deleted the revive_old_kf_codes branch September 2, 2014 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants