ブックマークが無いときの表示を変更 #3335
Merged
ブックマークが無いときの表示を変更 #3335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaiyu-tech |
kaiyu-tech
reviewed
Oct 1, 2021
app/javascript/bookmarks.vue
Outdated
Comment on lines
22
to
25
| .o-empty-message__icon | ||
| i.far.fa-sad-tear | ||
| p.o-empty-message__text | ||
| | ブックマークしているものはありません。 |
There was a problem hiding this comment.
動作確認してみましたが、以下のように表示されました。
以下のコードの部分のインデントが間違っているために、o-empty-message__textに対してo-empty-message__iconのスタイルが当たってしまっているようです。
Suggested change
| .o-empty-message__icon | |
| i.far.fa-sad-tear | |
| p.o-empty-message__text | |
| | ブックマークしているものはありません。 | |
| .o-empty-message__icon | |
| i.far.fa-sad-tear | |
| p.o-empty-message__text | |
| | ブックマークしているものはありません。 |
There was a problem hiding this comment.
slimで記述をするときにはインデントが重要なんですね！
理解できました😊
|
@kaiyu-tech |
|
@Ichiyo14 |
|
@kaiyu-tech @komagata |
14 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #3023
ブックマークが0件のときの表示を設定する。
#3307 に習い泣き顔を表示する。
修正前
## 修正後