Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

プラクティスに質問がない場合に泣き顔を表示するようにした #3307

Conversation

ghost
Copy link

@ghost ghost commented Sep 24, 2021

泣き顔を表示するようにしました。
他の場所で表示されている泣き顔を参考にしました。

@ghost ghost closed this Sep 24, 2021
@ghost ghost reopened this Sep 24, 2021
@ghost ghost marked this pull request as draft September 24, 2021 08:56
@ghost ghost marked this pull request as ready for review September 24, 2021 09:18
@ghost ghost marked this pull request as draft September 24, 2021 09:18
@ghost ghost requested a review from haruguchi-yuma September 24, 2021 09:23
@ghost ghost marked this pull request as ready for review September 24, 2021 09:24
@komagata
Copy link
Member

@sutehuna メンションなどで直接レビューを依頼してみてください〜(他の方のIssueでのやりとりが参考になりと思います〜)

@machida machida assigned ghost Sep 27, 2021
@ghost
Copy link
Author

ghost commented Sep 27, 2021

@haruguchi-yuma お手すきの際にこちらのレビューをお願いします。

Copy link
Contributor

@haruguchi-yuma haruguchi-yuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sutehuna
同じような処理をしている/users/:user_id/questionsを参考に判断しました。
LGTMですー!🙇‍♀️

@ghost ghost requested a review from komagata September 27, 2021 14:22
@ghost
Copy link
Author

ghost commented Sep 27, 2021

@komagata お手すきの際にこちらのレビューをお願いします。

Copy link
Member

@komagata komagata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました、OKですー🙆‍♂️

@komagata komagata merged commit 4904f16 into main Sep 28, 2021
@komagata komagata deleted the feature/change-appearance-of-practice-questions-when-no-questions branch September 28, 2021 17:49
@github-actions github-actions bot mentioned this pull request Sep 28, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants