schema, docs, and invoice cast updates #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
requested review from
kristin-bagnall and
fivetran-jamie
| @@ -11,6 +11,7 @@ models: | |||
|
|
|||
| vars: | |||
| quickbooks_source: | |||
| using_purchase_order: True | |||
There was a problem hiding this comment.
As the purchase order models are false by default, I decided to set the variable as true within the integration tests so the docs would still contain these models once we deploy to github pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
quickbooks_stagingschema as well as relevant README updates reflecting this change.deposit_to_account_idfield within the invoice staging model to address Issue Cast deposit_to_account_id as integer #8.docsfolder to allow for github pages docs site deployment once the branch is merged with master.