Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast deposit_to_account_id as integer #8

Closed
jamesrayoub opened this issue Feb 25, 2021 · 2 comments
Closed

Cast deposit_to_account_id as integer #8

jamesrayoub opened this issue Feb 25, 2021 · 2 comments

Comments

@jamesrayoub
Copy link
Contributor

In the Invoice staging model, deposit_to_account_id is currently represented as a string, but since we cast account_id in the Accounts model as an integer, this FK should also be cast as an int
@fivetran-joemarkiewicz
Copy link
Contributor

Thanks for catching this @jamesrayoub! We are planning an enhancement to the dbt_quickbooks package to include a monthly P&L model. We will incorporate this fix in those updates.

Merged
@fivetran-joemarkiewicz
Copy link
Contributor

This issue has been addressed within PR #9 and is now live within Release v0.2.0.

Keep an eye out on the dbt hub for when it is officially released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesrayoub @fivetran-joemarkiewicz