Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Improve JSX syntax highlighting #4539

Merged

Conversation

nyrosmith
Copy link
Contributor

Associated Issue: #3878

Using perf.html as an example also revealed a weakness in our logic to detect if it's a react component. So I extended utils/source.js to also take PureComponent into account.

Syntax highlighting of JSX after this changes:
jsx

@wldcordeiro
Copy link
Contributor

One concern is that JSX is used by more than React so we might wish to be more agnostic but I like this solution so far.

@nyrosmith
Copy link
Contributor Author

@wldcordeiro of course it can be improved but I think it's a good start.

@@ -9,6 +9,7 @@ import { isOriginalId } from "devtools-source-map";
import { endTruncateStr } from "./utils";
import { basename } from "../utils/path";
import { parse as parseURL } from "url";
import { isReactComponent } from "../workers/parser/frameworks";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, this call will have to be async because it requires parsing...

if we want to do this, we'll need to add it to another place, like on loadSourceText.
i'm not sure if we're already parsing

+export function setSourceMetaData(sourceId: SourceId) {
+  return async ({ dispatch, getState }: ThunkArgs) => {
+    const sourceRecord = getSource(getState(), sourceId);
+    if (!sourceRecord) {
+      return;
+    }
+
+    const source = sourceRecord.toJS();
+    if (!source.text || source.isWasm || hasSymbols(getState(), source)) {
+      return;
+    }
+
+    const isReactComponent = await isReactComponent(source.get("id"));
+    const hasJSX = await hasJSX(source.get("id"));
+
+    // would update the source record...
+    dispatch({
+      type: "SOURCE_META_DATA",
+      isReactComponent,
+      hasJSX
+    });
+  };
+}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in the worker is async. Also needs to be parsed

@nyrosmith nyrosmith changed the title Improve JSX syntax highlighting (WIP) Improve JSX syntax highlighting Oct 30, 2017
Copy link
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple small questions, but otherwise great

@@ -52,7 +53,7 @@ class Breakpoint extends Component<Props> {
const sourceId = selectedSource.get("id");
const line = toEditorLine(sourceId, breakpoint.location.line);

showSourceText(editor, selectedSource.toJS());
showSourceText(editor, selectedSource.toJS(), metaData);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codehag do we need showSourceText after the lifecycle work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why this is in addBreakpoint to be honest. this shouldnt be taken care of here -- it should be done with the lifecycle update... in fact the same can be said about everything that is happening with the editor.codemirror here. this is outside of the scope of this pr... good catch though

Copy link
Contributor

@codehag codehag Nov 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh ok i understand better. the naming is a bit off -- this should probably be renderBreakpoint; still not sure if we need showSourceText... this was added here: #3294

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #4579 and we can come back

@@ -38,7 +38,8 @@ export type ASTState = {
symbols: SymbolsMap,
emptyLines: EmptyLinesMap,
outOfScopeLocations: ?Array<AstLocation>,
preview: Preview
preview: Preview,
metaData: Object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets type it like this:

  type SourceId = string
  export type SourceMetaData = { .. }
  export type MetaDataMap = Map<SourceId, SourceMetaData>;

@@ -111,6 +113,10 @@ function update(
return initialState();
}

case "SET_METADATA": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps SET_SOURCE_METADATA would be clearer

@nyrosmith nyrosmith changed the title (WIP) Improve JSX syntax highlighting Improve JSX syntax highlighting Nov 3, 2017
@@ -167,4 +179,8 @@ export function getPreview(state: OuterState) {
return state.ast.get("preview");
}

export function getMetaData(state: OuterState) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, i think this should be getSourceMetaData(state: OuterState, source: Source) so that we scope it down.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we need source for in this selector?

@@ -29,6 +30,29 @@ const extraProps = {
react: { displayName: "this._reactInternalInstance.getName()" }
};

export function setMetaData(sourceId: SourceId) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add a jest unit test for this next to setSymbols

@@ -111,6 +119,10 @@ function update(
return initialState();
}

case "SET_SOURCE_METADATA": {
return state.set("metaData", action.metaData);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, I'd change this to look like empty lines: return state.setIn(["emptyLines", source.id], emptyLines);

@nyrosmith
Copy link
Contributor Author

@jasonLaster Changed to your suggestions.
I also refactored to have unified naming and added some tests

Copy link
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I’d like to get @codehag’s thoughts here as the sourceMetaData field is new.

@jasonLaster
Copy link
Contributor

A little bit of context on this PR. It turns out that codemirror has a great "JSX" mode, which is better than "JS" for showing... JSX.

This PR, takes advantage of @James300's isReactComponent function in the parser, to say "if the file has a component, lets use the JSX" mode.

The question is where should we store the "isReactComponent":

  1. a new Ast.sourceMetaData redux map
  2. a new field in the Sources.sources redux map
  3. a new field in symbols

The argument for (1) and (2) is that we will want to know if a source is special, i.e. a component, route, or any other special type of framework file. (1) is a normal form, (2) is denormalized.

The argument for (3) is that symbols is already storing lots of meta data about sources, such as all the functions, variables, ..., why not also store meta data about the source: "is a react component"....

@@ -45,5 +45,6 @@ export function loadSourceText(source: Source) {
await setSource(newSource);
await dispatch(setSymbols(source.id));
await dispatch(setEmptyLines(source.id));
await dispatch(setSourceMetaData(source.id));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonLaster, I think we should keep this like this for now -- it looks fine and we are doing the same thing anyway with setSymbols and setEmptyLines; but we should eventually revisit this, and ask some hard questions. Are these four dispatches truly independent, or are they all concerned with the same piece of data? If we step away from the implementation of loadSourceText; what is loadSourceText doing -- and when is it finished? what is the action to an outside observer (and not to someone who knows how the inside works)?

I would say this is the best approach for now, and we can change it later on, when we refactor this in earnest and ask these questions. for more information about redux antipatterns: reduxjs/redux#857; https://stackoverflow.com/questions/33220776/should-actions-like-showing-hiding-loading-screens-be-handled-by-reducers-to-rel/33226443#33226443

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep... this is definitely an interesting place to investigate. A bit of context:

  1. these actions could potentially be slow, so some of the dispatches are staggered to get the data when it's ready
  2. some of this is "do the simplest thing" because when we created actions/ast it wasn't clear if AST was a separate thing, or if setPreview should live w/ pause and setSymbols should live with sources...

would love to revisit this too :)

@jasonLaster jasonLaster merged commit 7ad9038 into firefox-devtools:master Nov 6, 2017
@julienw
Copy link
Contributor

julienw commented Nov 6, 2017

I still wonder why we don't use JSX mode for all JS code. :)

@nyrosmith
Copy link
Contributor Author

nyrosmith commented Nov 6, 2017

@julienw why does codemirror have different modes for js & jsx? What are the implications if we always use jsx mode?
I thought it's safer to only use jsx mode when needed but I'll stay on topic and do further investigation

@julienw
Copy link
Contributor

julienw commented Nov 7, 2017

They say there should be no drawback. But because they say it doesn't mean it's true ;)

I don't know why they have different modes -- I suppose this is historical.
One thing that comes to my mind is for scripts inlined in an HTML page -- maybe here JS is better ? What happens for JSX code in JS code in an inline script ? :) This is of course unusual but not impossible.

khal0988 pushed a commit to khal0988/debugger.html that referenced this pull request Nov 9, 2017
- unifies right click "Copy source URI" for tree view & tab view (firefox-devtools#4325)

bump lock file (firefox-devtools#4317)

Release (10/6) (firefox-devtools#4322)

Protect Worker and Browser Content Toolboxes (firefox-devtools#4331)

Use Flow for Proptype checking in Source Tree

Fix flow error

(wip) Show class functions in the outline! (firefox-devtools#4286)

WIP - Fix Secondary Panes Scroll Bar (firefox-devtools#4275)

Simplify Editor LifeCycle (firefox-devtools#4301)

Align empty message in Source Tab (firefox-devtools#4337)

Remove last vestige of devtools.debugger.client-source-maps-enabled (firefox-devtools#4339)

Fixed issue firefox-devtools#4291 (firefox-devtools#4340)

Update travis MC commit (firefox-devtools#4335)

Make alt click expand/collapse all the nodes

cleanup ...

Debugger Release  (firefox-devtools#4341)

Replace lodash find with native Array::find. Fixes firefox-devtools#4343. (firefox-devtools#4344)

add a GotoLineModal (firefox-devtools#4323)

This commit adds a gotoline modal/functionality triggered with `Cmd+:`
(`CtrlOrCmd+Shift+;`) in the main debugger source window.

A string that cannot be `parseInt()`'d is a noop. A number higher
than the number of lines in the file will go to the end of the file.

Upgrade Launchpad (firefox-devtools#4332)

Improve maintainer experience (firefox-devtools#4352)

Update sources arrow (firefox-devtools#4351)

fix browser toolbox issues (firefox-devtools#4347)

add getDomain tst (firefox-devtools#4356)

Tidies up reducer comments (firefox-devtools#4354)

modal height and position changed (firefox-devtools#4277)

travis bump (firefox-devtools#4358)

Improve triaging docs (firefox-devtools#4321)

Attempt to address "Debugger.Frame is not live".

[SourceTree] Set root directory (firefox-devtools#4363)

* Preview: Show numbers inside a tooltip (firefox-devtools#4164)

* initial commit

* resolved conflicts in src/actions/ui.js and updated debugger.properties and SourcesTree.js based on flodolo and jasonLaster feedback

* Update debugger.properties

fix key

remove svgs

Update Module Manifest

Update Module Manifest

Update Module Manifest

Update Module Manifest

Update Module Manifest

Update Module Manifest

Update Release (3)

Update Release (3)

Removed tabs + button (firefox-devtools#4367)

* Removed tabs + button

Issue firefox-devtools#4312
Removed:
- import of formatKeyShortcut
- onclick
- render newButton method
Kept:
SVG plus icon
L10N "sourceTabs.newTabButtonTooltip" key value pair

* Removed tabs + button

Issue firefox-devtools#4312
Removed:
- import of formatKeyShortcut
- onclick
- render newButton method
- debugger.properties sourceTabs.newTabButtonTooltip
Kept:
SVG plus icon

add docs on merge conflicts (firefox-devtools#4365)

File search reducer (firefox-devtools#4368)

Fixes mis-aligned tooltip (firefox-devtools#4370)

* Fixes mis-aligned tooltip

* tweaks

Fix Empty Lines off by one issue (firefox-devtools#4361)

get display name and pass it to Popup.js (firefox-devtools#4357)

small prettier changes (firefox-devtools#4364)

Adds L10N for  previously hardcoded keybindings (firefox-devtools#4378)

* Adds L10N for  previously hardcoded keybindings

* Updates keybindings as requested by owner

Update Release (10-13) (firefox-devtools#4380)

add shortcuts modal in vertical mode (firefox-devtools#4288) (firefox-devtools#4375)

Update Shortcuts button (firefox-devtools#4382)

docs most-common-issues (firefox-devtools#4295)

Use a monospace font for editor line numbers (firefox-devtools#4391)

Set layout change

Cleanup babel (firefox-devtools#4404)

Adds flow types to the Scope declaration. (firefox-devtools#4405)

Synchronize smoke test for browser content toolbox from m-c (firefox-devtools#4408)

Update mochii to the latest version 🚀 (firefox-devtools#4414)

Converted blackBox/prettyPrint SVG's to CSS (firefox-devtools#4386)

Revert "Use a monospace font for editor line numbers" (firefox-devtools#4416)

This reverts commit 2544fc1.

Fix "3" expressions

Fix firefox-devtools#4397 - Don't allow context menu when a line is empty

🔨: Rework `SourceSearch` into `SourcesModal` (firefox-devtools#4398)

Keeps focus on input field (firefox-devtools#4423)

add layout test (firefox-devtools#4415)

Change port 9000 default to 8116 default (firefox-devtools#4434)

Scroll to column (firefox-devtools#4143)

* fix issue with the line not highlighting in the editor

* undo some changes to test

* fix

* switch to watForLoaded

* flash line all ways

* fix the conditional breakpoint panel mochitest

* if there is no selected location bail early, fix a mochitest

* fix mochitests, cleanup index

* fix the dbg-tabs mochitest

* fix the breakpoint visible mochitest issue

* fix the failing unit tests

* stop nesting the location info

* more cleanups

Upgrade flow (firefox-devtools#4433)

* Upgrade Flow

* Use `static` properties for `defaultProps`

Flow uses the defaultProps static property to type the default props.

* Convert a set of components over to the new Flow syntax

* Remove a usage of 'createFactory'

* Convert another batch of components over to the new Flow syntax

* Convert yet another batch of components over to the new Flow syntax

* Remove unused file

This file was originally removed in 6ba9b0b. However, while merging in master in e60cedd, I accidentally added the file back.

* Don't type check devtools-reps

* Update ref for the ConditionalPanel

Per the Flow docs (https://flow.org/en/docs/react/refs/), we need to explicitly set the type of the ref and ensure that it is nullable.

* Convert more files to the new Flow syntax

* Update the last items for the new Flow syntax

* Only ignore the object-inspector

So that we can still import its types.

* Change flow types to use primitive values

Support framework frames for Marko (firefox-devtools#4430)

* added marko to library frames

* code simplified

* refactoring library map

* moving great before react

fix bug where the line being 0 returns a falsy (firefox-devtools#4445)

* fix bug where the line being 0 returns a falsy and does not cause the line to flash

* use isLoaded util

update 10-17-2017 (firefox-devtools#4400)

* update 10-17-2017

* update according to jlast's comments

* fix lint

bump yarn (firefox-devtools#4442)

Undo string change to editor.addConditionalBreakpoint (firefox-devtools#4448)

Working class and imports finder (firefox-devtools#4329)

10/13 2nd release (firefox-devtools#4447)

support framework frames for aframe (firefox-devtools#4458)

Fix warnings for var usage (firefox-devtools#4456)

bump launchpad (firefox-devtools#4452)

add support framework frames for Nuxt.js (firefox-devtools#2980) (firefox-devtools#4460)

Add Jest Cases

Fix links in debugging-the-debugger page

Fix links in getting-setup page

Fix links in getting-setup page 1

Blackboxed sources distinguished by icon in source tree  (firefox-devtools#4441)

Fixes 3846 Source Tabs and Gutter Column Don't Line Up (firefox-devtools#4427)

* Update PaneToggle.css

* Update Tabs.css

* fix for dynamic width

* error check for no element

* moving ui related utilities to utils/ui file

* adding export to each function

Update README.md

fix firefox-devtools#4471 - expand the right sidebar on pausing at breakpoint

event stopped for context menu for non firefox browsers

event prevent default moved

Add next.js to framework frames (firefox-devtools#4476)

Converted Source Tree SVG's (including Blackbox) to images using CSS styles (firefox-devtools#4350) (firefox-devtools#4477)

add the computed property to allow differentiating between computed and uncomputed memberexpressions

fix flow

move the func to a utility file

added tests

fix tests

Fix footer background length in dark theme

Highlight errors in editor

fix css linting errors

cleanup

Make error background color lighter

refactoring

fix getting the lineNo from CoideMirror (firefox-devtools#4466)

Move workflow to pr docs

(wip) Refactor pause actions (firefox-devtools#4439)

* Update Pause Semantics

[Issue-4486]-Changing the overflow rule of secondaryPanel to pr… (firefox-devtools#4487)

QuickOpenModal (firefox-devtools#4464)

Fix cross-configuration problems (firefox-devtools#4475)

* Add gitattributes

* fix: Multi-platform and configuration issues

This configures all systems to checkout and use LF line endings.

The jest test system also runs without colors by default now.
This allows the tests to pass in any environment regardless of color
scheme.

* tweaks

bump mochi

Close ConditionalPanel on blur

[Preview] Some lines are incorrectly marked as out of scope

Add travis notifications

🐛: Fix the quick-open mochitest

There were some race issues with the quick open mochitest assertions that this cleared up.

📝: Add some mochitest debugging tips.

Added some tips to the mochitest debugging docs based on experience
debugging race issue. Also
Prettier fixed some things.

tweaks

Weekly Post - 10-24 (firefox-devtools#4494)

Remove createClass and Proptypes warning (firefox-devtools#4510)

(firefox-devtools#4350) Converted Step Button SVG's to images using CSS Styles (firefox-devtools#4502)

notify on failure (firefox-devtools#4511)

Fixes firefox-devtools#4505 - Convert file SVG to image (firefox-devtools#4514)

add terminology (firefox-devtools#4512)

* add terminology

* Update terminology.md

fix l10n label (firefox-devtools#4518)

Fix parser returning failing to clone data (firefox-devtools#4520)

debugging firefox

add a use-case for feature flags

Update local-development.md

Unselects highlight on search window close

Updates tests

Fixing Shortcut Modal Dark Theme Legibility on Mac

Move selected PrimaryTab local state to redux

Fix typo

another typo

Cleanup

Move selected PrimaryTab local state to redux

🐛: Use onKeyDown in SearchBar to allow for simpler iteration of results (firefox-devtools#4533)

In the QuickOpenModal we found that using onKeyDown meant a user could hold up/down to traverse
their results more easily. In the searchbar holding enter does the same.

Closes firefox-devtools#2527

removes declared hooks on componentWillUnmount (firefox-devtools#4426)

* removes declared hooks on componentWillUnmount

* changes listener binding from fat arrow to bind(this)

Style debuggee domain (firefox-devtools#4536)

🎨: Update our symbol parsing code to extract additional function types (firefox-devtools#4531)

Remove query strings when displaying call stack frames (firefox-devtools#4535)

[firefox-devtools#4545] Add tests for src/utils/assert.js (firefox-devtools#4546)

Fix filename for assert.js tests

Add tests for src/utils/log.js

Displays result count only after initiating search (firefox-devtools#4525)

Use new redux action in editor (firefox-devtools#4552)

Refactor waitForPaused

colon removed from subtitle

CI fix

show better error messages in jest (firefox-devtools#4558)

Add timing data (firefox-devtools#4540)

Refactor command action to use PROMISE (firefox-devtools#4554)

* Refactor waitForPaused

* Refactor command to be async

Release 10/25 (firefox-devtools#4493)

10-31 (firefox-devtools#4543)

updates readme 10/31

Update mochii to the latest version 🚀 (firefox-devtools#4562)

Refactor map scopes to fetch scopes (firefox-devtools#4550)

bump map-bindings (firefox-devtools#4566)

togglePaneCollapse update (firefox-devtools#4508)

Validate scripts (firefox-devtools#4565)

do not expand all scope objects (firefox-devtools#4498)

Update mochii to the latest version 🚀 (firefox-devtools#4576)

Fix conditional breakpoints (firefox-devtools#4465)

Update github-airtable-bridge to the latest version 🚀 (firefox-devtools#4578)

Dont show Mochi output for passing tests (firefox-devtools#4580)

Add airtable crm config (firefox-devtools#4582)

Add Unit Tests for Editor (firefox-devtools#4522)

Moves redux middleware to actions/utils (firefox-devtools#4567)

* Moves redux middleware to actions/utils

* Fixes import path in Jest

* Changes directory from actions/utils to actions/utils/middleware

* moves create-store from utils/middleware to utils

Fix jest intermittent - quick open

FIX - cmd+shift+b is no longer bound (firefox-devtools#4595)

* cmd+shift+b is no longer bound - Fix

* Fix2 - cmd+shift+b is no longer bound

* action fix - cmd+shift+b is no longer bound

Re-enable tests (firefox-devtools#4564)

Improve JSX syntax highlighting (firefox-devtools#4539)

Mochi intermittent script (firefox-devtools#4586)

Disallow uncaught exceptions (firefox-devtools#4584)

Optimistically clear pause state (firefox-devtools#4557)

Competing Scripts - break webpack (firefox-devtools#4606)

* Competing Scripts - break webpack

* Update most-common-issues.md

Fixes secondary pane css classes being localized (firefox-devtools#4611)

Preview mochitest (firefox-devtools#4603)

Panel fixes (firefox-devtools#4598)

Add some additional helper methods

Exclude flow types from identifier locations

Add a license header (firefox-devtools#4601)

Fix display of return value / thrown exception in scopes (firefox-devtools#4569)

Adds mk_add_options AUTOCLOBBER=1 to .mozconfig (firefox-devtools#4622)

Add launchpad screenshot (firefox-devtools#4623)

bump bindings (firefox-devtools#4625)

fix markdown lint (firefox-devtools#4626)

Upgrade flow (firefox-devtools#4591)

spell check docs (firefox-devtools#4627)

Fix flow ignore (firefox-devtools#4628)

flash function when it is copied - feature firefox-devtools#4022 (firefox-devtools#4634)

added flash action

Update mochii to the latest version 🚀 (firefox-devtools#4638)

Issue ADD_SCOPES even for wasm files. (firefox-devtools#4637)

Issue firefox-devtools#4639 - bump devtools-reps to 0.12.4

Issue firefox-devtools#4639 - update yarn.lock

Replaces Object.assign with ... spread (firefox-devtools#4574)

Re-enable wasm test (firefox-devtools#4644)

Release the debugger (firefox-devtools#4633)

* Bug 4420 fix

* tweaks

Add small lint fixes
khal0988 pushed a commit to khal0988/debugger.html that referenced this pull request Nov 9, 2017
update feature flags

Preview: Show numbers inside a tooltip (firefox-devtools#4164)

bump mochii

Update devtools package

Preview: Show numbers inside a tooltip

fix the failing pending breakpoints tests (firefox-devtools#4175)

Switch Scopes form PropTypes to Flow Props (firefox-devtools#4180)

No domain (firefox-devtools#4159)

Adding "Add condition" to breakpoints context menu (firefox-devtools#4157)

Don't show "No sources" hint if sources panel is hidden (firefox-devtools#4179)

* Don't show "No sources" hint if sources panel is hidden

* Don't hide PrimaryPane components via css

* fix linting error

* remove unused import

Cleanup addbreakpoints (firefox-devtools#4184)

Show mapped names in scopes bindings (firefox-devtools#3817)

Flow types (firefox-devtools#4197)

* Fix flow error Footer

* Fix flow error Breakpint, Breakpoints

Fix breakpoint jumping (firefox-devtools#4191)

Validate expression syntax (firefox-devtools#4114)

* validate expressions

* add missing test

* bump mochii

Fix ESLint Dependencies from Fresh Install (firefox-devtools#4178)

* Add dependencies for linting

* Fix linting errors in master

* Fix package.json lint errors

Fix firefox-devtools#4043 - Change localization note and errorLoadingText (firefox-devtools#4058)

Fix linting warnings (firefox-devtools#4204)

Small style improvements on breakpoint and watch expression (firefox-devtools#4057)

* PR#4057 - PART1: [breakpoint] small style improvements

* PR#4057 - PART2: [watch expression] small style improvements

9-27 update (firefox-devtools#4193)

Shortcuts style tweak (firefox-devtools#4202)

Scroll bar is not ignored in vertical mode calculations (firefox-devtools#4127)

Bump react to 15.6.2 (firefox-devtools#4160)

Upgrade tree component (firefox-devtools#4215)

Revert "Upgrade tree component (firefox-devtools#4215)" (firefox-devtools#4224)

This reverts commit 179582c.

Switch Popover PropTypes to flow props (firefox-devtools#4227)

Fix source tabs not lining up with file tabs (firefox-devtools#4139)

memoize loading (firefox-devtools#4216)

Issue firefox-devtools#3966: Show small values inside tooltip (firefox-devtools#4218)

add line about vulnerabilities (firefox-devtools#4231)

Fix responsive issue on WelcomeBox (firefox-devtools#4119)

remove paused class (firefox-devtools#4235)

Fix webpack icon matching (firefox-devtools#4240)

bump 9-29 (firefox-devtools#4214)

* bump 9-29

* Revert "Upgrade tree component (firefox-devtools#4215)"

This reverts commit 179582c.

* assets

Update devtools-source-map to the latest version 🚀 (firefox-devtools#4222)

* fix(package): update devtools-source-map to version 0.14.2

* fix update script

* bump yarn

Fix some lingering POE + Exception bugs (firefox-devtools#4225)

firefox doesn't like fit-content (firefox-devtools#4219)

Disables updateScopeBindings for wasm source maps. (firefox-devtools#4245)

React preview (firefox-devtools#4228)

Moved workers to their own Worker directory. (firefox-devtools#4230)

Show the full url of a file in the source tab tooltip (firefox-devtools#4203) (firefox-devtools#4226)

Fixed Webpack Alignment (firefox-devtools#4250)

AST Test (firefox-devtools#4249)

remove unnecessary line

Fix 4246 - Prevent validateDOMNesting warning (firefox-devtools#4247)

remove mocha (firefox-devtools#4254)

Claim an issue (firefox-devtools#4255)

Fix some react test warnings (firefox-devtools#4248)

Adds readme with debugger.html version information to mc.

Fix prop-type warnings (firefox-devtools#4257)

* Add separate prop-types dependency

Using prop types from the React repo has been deprecated.

* Alphabetize dependencies and remove duplicates

Remove usage of create factory (firefox-devtools#4260)

Lint equality (firefox-devtools#4278)

* Updated text after equality linting

* clean up

Migrate ManagedTree proptypes to flow (firefox-devtools#4272)

Add Command Slash Shortcut (firefox-devtools#4265)

Closes firefox-devtools#4213

Stop breakpoint label click from toggling breakpoint (firefox-devtools#4269)

Addresses firefox-devtools#4262

Provides the primary purpose of linking to the breakpoint's location in
source.

Extract temp variables for wrapped components in their tests (firefox-devtools#4279)

[firefox-devtools#4270] Add tests for DevToolsUtils (firefox-devtools#4271)

Optimize addToTree function. (firefox-devtools#4263)

Fix one case of different lodash import format (firefox-devtools#4289)

Make keyboard shortcuts button more specific and localized (firefox-devtools#4293)

Fixing source-documents linting error (firefox-devtools#4290)

Fix 4261 - Sort breakpoints by line number (firefox-devtools#4264)

* Fix 4261 - Sort breakpoints by line number

* Fix flow issues

* Use lodash's sortBy for breakpoint sorting

Remove object.assign from selectors.js close firefox-devtools#4267 (firefox-devtools#4268)

Removes unneeded SVG DOM elements for source tree arrows. (firefox-devtools#4283)

Added step over functionality for yield (firefox-devtools#4232) (firefox-devtools#4276)

* Added step over functionality for yield (firefox-devtools#4232)

* Consistent parser steps naming and generators fixture

Proposal for closing firefox-devtools#3172 (firefox-devtools#4266)

Updating docs (firefox-devtools#4298)

Support framework frames for Preact (firefox-devtools#4296)

Attempt to reduce intermittent failures for wasm-sourcemaps test. (firefox-devtools#4305)

Fix Source Tree padding left (firefox-devtools#4303)

* Fix Source Tree padding left

* change to match the top ooutline spacing

Change component function binding to class properties (firefox-devtools#4302)

show mapped names in watch expressions (firefox-devtools#4206)

- unifies right click "Copy source URI" for tree view & tab view (firefox-devtools#4325)

bump lock file (firefox-devtools#4317)

Release (10/6) (firefox-devtools#4322)

Protect Worker and Browser Content Toolboxes (firefox-devtools#4331)

Use Flow for Proptype checking in Source Tree

Fix flow error

(wip) Show class functions in the outline! (firefox-devtools#4286)

WIP - Fix Secondary Panes Scroll Bar (firefox-devtools#4275)

Simplify Editor LifeCycle (firefox-devtools#4301)

Align empty message in Source Tab (firefox-devtools#4337)

Remove last vestige of devtools.debugger.client-source-maps-enabled (firefox-devtools#4339)

Fixed issue firefox-devtools#4291 (firefox-devtools#4340)

Update travis MC commit (firefox-devtools#4335)

Make alt click expand/collapse all the nodes

cleanup ...

Debugger Release  (firefox-devtools#4341)

Replace lodash find with native Array::find. Fixes firefox-devtools#4343. (firefox-devtools#4344)

add a GotoLineModal (firefox-devtools#4323)

This commit adds a gotoline modal/functionality triggered with `Cmd+:`
(`CtrlOrCmd+Shift+;`) in the main debugger source window.

A string that cannot be `parseInt()`'d is a noop. A number higher
than the number of lines in the file will go to the end of the file.

Upgrade Launchpad (firefox-devtools#4332)

Improve maintainer experience (firefox-devtools#4352)

Update sources arrow (firefox-devtools#4351)

fix browser toolbox issues (firefox-devtools#4347)

add getDomain tst (firefox-devtools#4356)

Tidies up reducer comments (firefox-devtools#4354)

modal height and position changed (firefox-devtools#4277)

travis bump (firefox-devtools#4358)

Improve triaging docs (firefox-devtools#4321)

Attempt to address "Debugger.Frame is not live".

[SourceTree] Set root directory (firefox-devtools#4363)

* Preview: Show numbers inside a tooltip (firefox-devtools#4164)

* initial commit

* resolved conflicts in src/actions/ui.js and updated debugger.properties and SourcesTree.js based on flodolo and jasonLaster feedback

* Update debugger.properties

fix key

remove svgs

Update Module Manifest

Update Module Manifest

Update Module Manifest

Update Module Manifest

Update Module Manifest

Update Module Manifest

Update Release (3)

Update Release (3)

Removed tabs + button (firefox-devtools#4367)

* Removed tabs + button

Issue firefox-devtools#4312
Removed:
- import of formatKeyShortcut
- onclick
- render newButton method
Kept:
SVG plus icon
L10N "sourceTabs.newTabButtonTooltip" key value pair

* Removed tabs + button

Issue firefox-devtools#4312
Removed:
- import of formatKeyShortcut
- onclick
- render newButton method
- debugger.properties sourceTabs.newTabButtonTooltip
Kept:
SVG plus icon

add docs on merge conflicts (firefox-devtools#4365)

File search reducer (firefox-devtools#4368)

Fixes mis-aligned tooltip (firefox-devtools#4370)

* Fixes mis-aligned tooltip

* tweaks

Fix Empty Lines off by one issue (firefox-devtools#4361)

get display name and pass it to Popup.js (firefox-devtools#4357)

small prettier changes (firefox-devtools#4364)

Adds L10N for  previously hardcoded keybindings (firefox-devtools#4378)

* Adds L10N for  previously hardcoded keybindings

* Updates keybindings as requested by owner

Update Release (10-13) (firefox-devtools#4380)

add shortcuts modal in vertical mode (firefox-devtools#4288) (firefox-devtools#4375)

Update Shortcuts button (firefox-devtools#4382)

docs most-common-issues (firefox-devtools#4295)

Use a monospace font for editor line numbers (firefox-devtools#4391)

Set layout change

Cleanup babel (firefox-devtools#4404)

Adds flow types to the Scope declaration. (firefox-devtools#4405)

Synchronize smoke test for browser content toolbox from m-c (firefox-devtools#4408)

Update mochii to the latest version 🚀 (firefox-devtools#4414)

Converted blackBox/prettyPrint SVG's to CSS (firefox-devtools#4386)

Revert "Use a monospace font for editor line numbers" (firefox-devtools#4416)

This reverts commit 2544fc1.

Fix "3" expressions

Fix firefox-devtools#4397 - Don't allow context menu when a line is empty

🔨: Rework `SourceSearch` into `SourcesModal` (firefox-devtools#4398)

Keeps focus on input field (firefox-devtools#4423)

add layout test (firefox-devtools#4415)

Change port 9000 default to 8116 default (firefox-devtools#4434)

Scroll to column (firefox-devtools#4143)

* fix issue with the line not highlighting in the editor

* undo some changes to test

* fix

* switch to watForLoaded

* flash line all ways

* fix the conditional breakpoint panel mochitest

* if there is no selected location bail early, fix a mochitest

* fix mochitests, cleanup index

* fix the dbg-tabs mochitest

* fix the breakpoint visible mochitest issue

* fix the failing unit tests

* stop nesting the location info

* more cleanups

Upgrade flow (firefox-devtools#4433)

* Upgrade Flow

* Use `static` properties for `defaultProps`

Flow uses the defaultProps static property to type the default props.

* Convert a set of components over to the new Flow syntax

* Remove a usage of 'createFactory'

* Convert another batch of components over to the new Flow syntax

* Convert yet another batch of components over to the new Flow syntax

* Remove unused file

This file was originally removed in 6ba9b0b. However, while merging in master in e60cedd, I accidentally added the file back.

* Don't type check devtools-reps

* Update ref for the ConditionalPanel

Per the Flow docs (https://flow.org/en/docs/react/refs/), we need to explicitly set the type of the ref and ensure that it is nullable.

* Convert more files to the new Flow syntax

* Update the last items for the new Flow syntax

* Only ignore the object-inspector

So that we can still import its types.

* Change flow types to use primitive values

Support framework frames for Marko (firefox-devtools#4430)

* added marko to library frames

* code simplified

* refactoring library map

* moving great before react

fix bug where the line being 0 returns a falsy (firefox-devtools#4445)

* fix bug where the line being 0 returns a falsy and does not cause the line to flash

* use isLoaded util

update 10-17-2017 (firefox-devtools#4400)

* update 10-17-2017

* update according to jlast's comments

* fix lint

bump yarn (firefox-devtools#4442)

Undo string change to editor.addConditionalBreakpoint (firefox-devtools#4448)

Working class and imports finder (firefox-devtools#4329)

10/13 2nd release (firefox-devtools#4447)

support framework frames for aframe (firefox-devtools#4458)

Fix warnings for var usage (firefox-devtools#4456)

bump launchpad (firefox-devtools#4452)

add support framework frames for Nuxt.js (firefox-devtools#2980) (firefox-devtools#4460)

Add Jest Cases

Fix links in debugging-the-debugger page

Fix links in getting-setup page

Fix links in getting-setup page 1

Blackboxed sources distinguished by icon in source tree  (firefox-devtools#4441)

Fixes 3846 Source Tabs and Gutter Column Don't Line Up (firefox-devtools#4427)

* Update PaneToggle.css

* Update Tabs.css

* fix for dynamic width

* error check for no element

* moving ui related utilities to utils/ui file

* adding export to each function

Update README.md

fix firefox-devtools#4471 - expand the right sidebar on pausing at breakpoint

event stopped for context menu for non firefox browsers

event prevent default moved

Add next.js to framework frames (firefox-devtools#4476)

Converted Source Tree SVG's (including Blackbox) to images using CSS styles (firefox-devtools#4350) (firefox-devtools#4477)

add the computed property to allow differentiating between computed and uncomputed memberexpressions

fix flow

move the func to a utility file

added tests

fix tests

Fix footer background length in dark theme

Highlight errors in editor

fix css linting errors

cleanup

Make error background color lighter

refactoring

fix getting the lineNo from CoideMirror (firefox-devtools#4466)

Move workflow to pr docs

(wip) Refactor pause actions (firefox-devtools#4439)

* Update Pause Semantics

[Issue-4486]-Changing the overflow rule of secondaryPanel to pr… (firefox-devtools#4487)

QuickOpenModal (firefox-devtools#4464)

Fix cross-configuration problems (firefox-devtools#4475)

* Add gitattributes

* fix: Multi-platform and configuration issues

This configures all systems to checkout and use LF line endings.

The jest test system also runs without colors by default now.
This allows the tests to pass in any environment regardless of color
scheme.

* tweaks

bump mochi

Close ConditionalPanel on blur

[Preview] Some lines are incorrectly marked as out of scope

Add travis notifications

🐛: Fix the quick-open mochitest

There were some race issues with the quick open mochitest assertions that this cleared up.

📝: Add some mochitest debugging tips.

Added some tips to the mochitest debugging docs based on experience
debugging race issue. Also
Prettier fixed some things.

tweaks

Weekly Post - 10-24 (firefox-devtools#4494)

Remove createClass and Proptypes warning (firefox-devtools#4510)

(firefox-devtools#4350) Converted Step Button SVG's to images using CSS Styles (firefox-devtools#4502)

notify on failure (firefox-devtools#4511)

Fixes firefox-devtools#4505 - Convert file SVG to image (firefox-devtools#4514)

add terminology (firefox-devtools#4512)

* add terminology

* Update terminology.md

fix l10n label (firefox-devtools#4518)

Fix parser returning failing to clone data (firefox-devtools#4520)

debugging firefox

add a use-case for feature flags

Update local-development.md

Unselects highlight on search window close

Updates tests

Fixing Shortcut Modal Dark Theme Legibility on Mac

Move selected PrimaryTab local state to redux

Fix typo

another typo

Cleanup

Move selected PrimaryTab local state to redux

🐛: Use onKeyDown in SearchBar to allow for simpler iteration of results (firefox-devtools#4533)

In the QuickOpenModal we found that using onKeyDown meant a user could hold up/down to traverse
their results more easily. In the searchbar holding enter does the same.

Closes firefox-devtools#2527

removes declared hooks on componentWillUnmount (firefox-devtools#4426)

* removes declared hooks on componentWillUnmount

* changes listener binding from fat arrow to bind(this)

Style debuggee domain (firefox-devtools#4536)

🎨: Update our symbol parsing code to extract additional function types (firefox-devtools#4531)

Remove query strings when displaying call stack frames (firefox-devtools#4535)

[firefox-devtools#4545] Add tests for src/utils/assert.js (firefox-devtools#4546)

Fix filename for assert.js tests

Add tests for src/utils/log.js

Displays result count only after initiating search (firefox-devtools#4525)

Use new redux action in editor (firefox-devtools#4552)

Refactor waitForPaused

colon removed from subtitle

CI fix

show better error messages in jest (firefox-devtools#4558)

Add timing data (firefox-devtools#4540)

Refactor command action to use PROMISE (firefox-devtools#4554)

* Refactor waitForPaused

* Refactor command to be async

Release 10/25 (firefox-devtools#4493)

10-31 (firefox-devtools#4543)

updates readme 10/31

Update mochii to the latest version 🚀 (firefox-devtools#4562)

Refactor map scopes to fetch scopes (firefox-devtools#4550)

bump map-bindings (firefox-devtools#4566)

togglePaneCollapse update (firefox-devtools#4508)

Validate scripts (firefox-devtools#4565)

do not expand all scope objects (firefox-devtools#4498)

Update mochii to the latest version 🚀 (firefox-devtools#4576)

Fix conditional breakpoints (firefox-devtools#4465)

Update github-airtable-bridge to the latest version 🚀 (firefox-devtools#4578)

Dont show Mochi output for passing tests (firefox-devtools#4580)

Add airtable crm config (firefox-devtools#4582)

Add Unit Tests for Editor (firefox-devtools#4522)

Moves redux middleware to actions/utils (firefox-devtools#4567)

* Moves redux middleware to actions/utils

* Fixes import path in Jest

* Changes directory from actions/utils to actions/utils/middleware

* moves create-store from utils/middleware to utils

Fix jest intermittent - quick open

FIX - cmd+shift+b is no longer bound (firefox-devtools#4595)

* cmd+shift+b is no longer bound - Fix

* Fix2 - cmd+shift+b is no longer bound

* action fix - cmd+shift+b is no longer bound

Re-enable tests (firefox-devtools#4564)

Improve JSX syntax highlighting (firefox-devtools#4539)

Mochi intermittent script (firefox-devtools#4586)

Disallow uncaught exceptions (firefox-devtools#4584)

Optimistically clear pause state (firefox-devtools#4557)

Competing Scripts - break webpack (firefox-devtools#4606)

* Competing Scripts - break webpack

* Update most-common-issues.md

Fixes secondary pane css classes being localized (firefox-devtools#4611)

Preview mochitest (firefox-devtools#4603)

Panel fixes (firefox-devtools#4598)

Add some additional helper methods

Exclude flow types from identifier locations

Add a license header (firefox-devtools#4601)

Fix display of return value / thrown exception in scopes (firefox-devtools#4569)

Adds mk_add_options AUTOCLOBBER=1 to .mozconfig (firefox-devtools#4622)

Add launchpad screenshot (firefox-devtools#4623)

bump bindings (firefox-devtools#4625)

fix markdown lint (firefox-devtools#4626)

Upgrade flow (firefox-devtools#4591)

spell check docs (firefox-devtools#4627)

Fix flow ignore (firefox-devtools#4628)

flash function when it is copied - feature firefox-devtools#4022 (firefox-devtools#4634)

added flash action

Update mochii to the latest version 🚀 (firefox-devtools#4638)

Issue ADD_SCOPES even for wasm files. (firefox-devtools#4637)

Issue firefox-devtools#4639 - bump devtools-reps to 0.12.4

Issue firefox-devtools#4639 - update yarn.lock

Replaces Object.assign with ... spread (firefox-devtools#4574)

Re-enable wasm test (firefox-devtools#4644)

Release the debugger (firefox-devtools#4633)

* Bug 4420 fix

* tweaks

Add small lint fixes
khal0988 pushed a commit to khal0988/debugger.html that referenced this pull request Nov 12, 2017
bump mochii

Update devtools package

Preview: Show numbers inside a tooltip

fix the failing pending breakpoints tests (firefox-devtools#4175)

Switch Scopes form PropTypes to Flow Props (firefox-devtools#4180)

No domain (firefox-devtools#4159)

Adding "Add condition" to breakpoints context menu (firefox-devtools#4157)

Don't show "No sources" hint if sources panel is hidden (firefox-devtools#4179)

* Don't show "No sources" hint if sources panel is hidden

* Don't hide PrimaryPane components via css

* fix linting error

* remove unused import

Cleanup addbreakpoints (firefox-devtools#4184)

Show mapped names in scopes bindings (firefox-devtools#3817)

Flow types (firefox-devtools#4197)

* Fix flow error Footer

* Fix flow error Breakpint, Breakpoints

Fix breakpoint jumping (firefox-devtools#4191)

Validate expression syntax (firefox-devtools#4114)

* validate expressions

* add missing test

* bump mochii

Fix ESLint Dependencies from Fresh Install (firefox-devtools#4178)

* Add dependencies for linting

* Fix linting errors in master

* Fix package.json lint errors

Fix firefox-devtools#4043 - Change localization note and errorLoadingText (firefox-devtools#4058)

Fix linting warnings (firefox-devtools#4204)

Small style improvements on breakpoint and watch expression (firefox-devtools#4057)

* PR#4057 - PART1: [breakpoint] small style improvements

* PR#4057 - PART2: [watch expression] small style improvements

9-27 update (firefox-devtools#4193)

Shortcuts style tweak (firefox-devtools#4202)

Scroll bar is not ignored in vertical mode calculations (firefox-devtools#4127)

Bump react to 15.6.2 (firefox-devtools#4160)

Upgrade tree component (firefox-devtools#4215)

Revert "Upgrade tree component (firefox-devtools#4215)" (firefox-devtools#4224)

This reverts commit 179582c.

Switch Popover PropTypes to flow props (firefox-devtools#4227)

Fix source tabs not lining up with file tabs (firefox-devtools#4139)

memoize loading (firefox-devtools#4216)

Issue firefox-devtools#3966: Show small values inside tooltip (firefox-devtools#4218)

add line about vulnerabilities (firefox-devtools#4231)

Fix responsive issue on WelcomeBox (firefox-devtools#4119)

remove paused class (firefox-devtools#4235)

Fix webpack icon matching (firefox-devtools#4240)

bump 9-29 (firefox-devtools#4214)

* bump 9-29

* Revert "Upgrade tree component (firefox-devtools#4215)"

This reverts commit 179582c.

* assets

Update devtools-source-map to the latest version 🚀 (firefox-devtools#4222)

* fix(package): update devtools-source-map to version 0.14.2

* fix update script

* bump yarn

Fix some lingering POE + Exception bugs (firefox-devtools#4225)

firefox doesn't like fit-content (firefox-devtools#4219)

Disables updateScopeBindings for wasm source maps. (firefox-devtools#4245)

React preview (firefox-devtools#4228)

Moved workers to their own Worker directory. (firefox-devtools#4230)

Show the full url of a file in the source tab tooltip (firefox-devtools#4203) (firefox-devtools#4226)

Fixed Webpack Alignment (firefox-devtools#4250)

AST Test (firefox-devtools#4249)

remove unnecessary line

Fix 4246 - Prevent validateDOMNesting warning (firefox-devtools#4247)

remove mocha (firefox-devtools#4254)

Claim an issue (firefox-devtools#4255)

Fix some react test warnings (firefox-devtools#4248)

Adds readme with debugger.html version information to mc.

Fix prop-type warnings (firefox-devtools#4257)

* Add separate prop-types dependency

Using prop types from the React repo has been deprecated.

* Alphabetize dependencies and remove duplicates

Remove usage of create factory (firefox-devtools#4260)

Lint equality (firefox-devtools#4278)

* Updated text after equality linting

* clean up

Migrate ManagedTree proptypes to flow (firefox-devtools#4272)

Add Command Slash Shortcut (firefox-devtools#4265)

Closes firefox-devtools#4213

Stop breakpoint label click from toggling breakpoint (firefox-devtools#4269)

Addresses firefox-devtools#4262

Provides the primary purpose of linking to the breakpoint's location in
source.

Extract temp variables for wrapped components in their tests (firefox-devtools#4279)

[firefox-devtools#4270] Add tests for DevToolsUtils (firefox-devtools#4271)

Optimize addToTree function. (firefox-devtools#4263)

Fix one case of different lodash import format (firefox-devtools#4289)

Make keyboard shortcuts button more specific and localized (firefox-devtools#4293)

Fixing source-documents linting error (firefox-devtools#4290)

Fix 4261 - Sort breakpoints by line number (firefox-devtools#4264)

* Fix 4261 - Sort breakpoints by line number

* Fix flow issues

* Use lodash's sortBy for breakpoint sorting

Remove object.assign from selectors.js close firefox-devtools#4267 (firefox-devtools#4268)

Removes unneeded SVG DOM elements for source tree arrows. (firefox-devtools#4283)

Added step over functionality for yield (firefox-devtools#4232) (firefox-devtools#4276)

* Added step over functionality for yield (firefox-devtools#4232)

* Consistent parser steps naming and generators fixture

Proposal for closing firefox-devtools#3172 (firefox-devtools#4266)

Updating docs (firefox-devtools#4298)

Support framework frames for Preact (firefox-devtools#4296)

Attempt to reduce intermittent failures for wasm-sourcemaps test. (firefox-devtools#4305)

Fix Source Tree padding left (firefox-devtools#4303)

* Fix Source Tree padding left

* change to match the top ooutline spacing

Change component function binding to class properties (firefox-devtools#4302)

show mapped names in watch expressions (firefox-devtools#4206)

- unifies right click "Copy source URI" for tree view & tab view (firefox-devtools#4325)

bump lock file (firefox-devtools#4317)

Release (10/6) (firefox-devtools#4322)

Protect Worker and Browser Content Toolboxes (firefox-devtools#4331)

Use Flow for Proptype checking in Source Tree

Fix flow error

(wip) Show class functions in the outline! (firefox-devtools#4286)

WIP - Fix Secondary Panes Scroll Bar (firefox-devtools#4275)

Simplify Editor LifeCycle (firefox-devtools#4301)

Align empty message in Source Tab (firefox-devtools#4337)

Remove last vestige of devtools.debugger.client-source-maps-enabled (firefox-devtools#4339)

Fixed issue firefox-devtools#4291 (firefox-devtools#4340)

Update travis MC commit (firefox-devtools#4335)

Make alt click expand/collapse all the nodes

cleanup ...

Debugger Release  (firefox-devtools#4341)

Replace lodash find with native Array::find. Fixes firefox-devtools#4343. (firefox-devtools#4344)

add a GotoLineModal (firefox-devtools#4323)

This commit adds a gotoline modal/functionality triggered with `Cmd+:`
(`CtrlOrCmd+Shift+;`) in the main debugger source window.

A string that cannot be `parseInt()`'d is a noop. A number higher
than the number of lines in the file will go to the end of the file.

Upgrade Launchpad (firefox-devtools#4332)

Improve maintainer experience (firefox-devtools#4352)

Update sources arrow (firefox-devtools#4351)

fix browser toolbox issues (firefox-devtools#4347)

add getDomain tst (firefox-devtools#4356)

Tidies up reducer comments (firefox-devtools#4354)

modal height and position changed (firefox-devtools#4277)

travis bump (firefox-devtools#4358)

Improve triaging docs (firefox-devtools#4321)

Attempt to address "Debugger.Frame is not live".

[SourceTree] Set root directory (firefox-devtools#4363)

* Preview: Show numbers inside a tooltip (firefox-devtools#4164)

* initial commit

* resolved conflicts in src/actions/ui.js and updated debugger.properties and SourcesTree.js based on flodolo and jasonLaster feedback

* Update debugger.properties

fix key

remove svgs

Update Module Manifest

Update Module Manifest

Update Module Manifest

Update Module Manifest

Update Module Manifest

Update Module Manifest

Update Release (3)

Update Release (3)

Removed tabs + button (firefox-devtools#4367)

* Removed tabs + button

Issue firefox-devtools#4312
Removed:
- import of formatKeyShortcut
- onclick
- render newButton method
Kept:
SVG plus icon
L10N "sourceTabs.newTabButtonTooltip" key value pair

* Removed tabs + button

Issue firefox-devtools#4312
Removed:
- import of formatKeyShortcut
- onclick
- render newButton method
- debugger.properties sourceTabs.newTabButtonTooltip
Kept:
SVG plus icon

add docs on merge conflicts (firefox-devtools#4365)

File search reducer (firefox-devtools#4368)

Fixes mis-aligned tooltip (firefox-devtools#4370)

* Fixes mis-aligned tooltip

* tweaks

Fix Empty Lines off by one issue (firefox-devtools#4361)

get display name and pass it to Popup.js (firefox-devtools#4357)

small prettier changes (firefox-devtools#4364)

Adds L10N for  previously hardcoded keybindings (firefox-devtools#4378)

* Adds L10N for  previously hardcoded keybindings

* Updates keybindings as requested by owner

Update Release (10-13) (firefox-devtools#4380)

add shortcuts modal in vertical mode (firefox-devtools#4288) (firefox-devtools#4375)

Update Shortcuts button (firefox-devtools#4382)

docs most-common-issues (firefox-devtools#4295)

Use a monospace font for editor line numbers (firefox-devtools#4391)

Set layout change

Cleanup babel (firefox-devtools#4404)

Adds flow types to the Scope declaration. (firefox-devtools#4405)

Synchronize smoke test for browser content toolbox from m-c (firefox-devtools#4408)

Update mochii to the latest version 🚀 (firefox-devtools#4414)

Converted blackBox/prettyPrint SVG's to CSS (firefox-devtools#4386)

Revert "Use a monospace font for editor line numbers" (firefox-devtools#4416)

This reverts commit 2544fc1.

Fix "3" expressions

Fix firefox-devtools#4397 - Don't allow context menu when a line is empty

🔨: Rework `SourceSearch` into `SourcesModal` (firefox-devtools#4398)

Keeps focus on input field (firefox-devtools#4423)

add layout test (firefox-devtools#4415)

Change port 9000 default to 8116 default (firefox-devtools#4434)

Scroll to column (firefox-devtools#4143)

* fix issue with the line not highlighting in the editor

* undo some changes to test

* fix

* switch to watForLoaded

* flash line all ways

* fix the conditional breakpoint panel mochitest

* if there is no selected location bail early, fix a mochitest

* fix mochitests, cleanup index

* fix the dbg-tabs mochitest

* fix the breakpoint visible mochitest issue

* fix the failing unit tests

* stop nesting the location info

* more cleanups

Upgrade flow (firefox-devtools#4433)

* Upgrade Flow

* Use `static` properties for `defaultProps`

Flow uses the defaultProps static property to type the default props.

* Convert a set of components over to the new Flow syntax

* Remove a usage of 'createFactory'

* Convert another batch of components over to the new Flow syntax

* Convert yet another batch of components over to the new Flow syntax

* Remove unused file

This file was originally removed in 6ba9b0b. However, while merging in master in e60cedd, I accidentally added the file back.

* Don't type check devtools-reps

* Update ref for the ConditionalPanel

Per the Flow docs (https://flow.org/en/docs/react/refs/), we need to explicitly set the type of the ref and ensure that it is nullable.

* Convert more files to the new Flow syntax

* Update the last items for the new Flow syntax

* Only ignore the object-inspector

So that we can still import its types.

* Change flow types to use primitive values

Support framework frames for Marko (firefox-devtools#4430)

* added marko to library frames

* code simplified

* refactoring library map

* moving great before react

fix bug where the line being 0 returns a falsy (firefox-devtools#4445)

* fix bug where the line being 0 returns a falsy and does not cause the line to flash

* use isLoaded util

update 10-17-2017 (firefox-devtools#4400)

* update 10-17-2017

* update according to jlast's comments

* fix lint

bump yarn (firefox-devtools#4442)

Undo string change to editor.addConditionalBreakpoint (firefox-devtools#4448)

Working class and imports finder (firefox-devtools#4329)

10/13 2nd release (firefox-devtools#4447)

support framework frames for aframe (firefox-devtools#4458)

Fix warnings for var usage (firefox-devtools#4456)

bump launchpad (firefox-devtools#4452)

add support framework frames for Nuxt.js (firefox-devtools#2980) (firefox-devtools#4460)

Add Jest Cases

Fix links in debugging-the-debugger page

Fix links in getting-setup page

Fix links in getting-setup page 1

Blackboxed sources distinguished by icon in source tree  (firefox-devtools#4441)

Fixes 3846 Source Tabs and Gutter Column Don't Line Up (firefox-devtools#4427)

* Update PaneToggle.css

* Update Tabs.css

* fix for dynamic width

* error check for no element

* moving ui related utilities to utils/ui file

* adding export to each function

Update README.md

fix firefox-devtools#4471 - expand the right sidebar on pausing at breakpoint

event stopped for context menu for non firefox browsers

event prevent default moved

Add next.js to framework frames (firefox-devtools#4476)

Converted Source Tree SVG's (including Blackbox) to images using CSS styles (firefox-devtools#4350) (firefox-devtools#4477)

add the computed property to allow differentiating between computed and uncomputed memberexpressions

fix flow

move the func to a utility file

added tests

fix tests

Fix footer background length in dark theme

Highlight errors in editor

fix css linting errors

cleanup

Make error background color lighter

refactoring

fix getting the lineNo from CoideMirror (firefox-devtools#4466)

Move workflow to pr docs

(wip) Refactor pause actions (firefox-devtools#4439)

* Update Pause Semantics

[Issue-4486]-Changing the overflow rule of secondaryPanel to pr… (firefox-devtools#4487)

QuickOpenModal (firefox-devtools#4464)

Fix cross-configuration problems (firefox-devtools#4475)

* Add gitattributes

* fix: Multi-platform and configuration issues

This configures all systems to checkout and use LF line endings.

The jest test system also runs without colors by default now.
This allows the tests to pass in any environment regardless of color
scheme.

* tweaks

bump mochi

Close ConditionalPanel on blur

[Preview] Some lines are incorrectly marked as out of scope

Add travis notifications

🐛: Fix the quick-open mochitest

There were some race issues with the quick open mochitest assertions that this cleared up.

📝: Add some mochitest debugging tips.

Added some tips to the mochitest debugging docs based on experience
debugging race issue. Also
Prettier fixed some things.

tweaks

Weekly Post - 10-24 (firefox-devtools#4494)

Remove createClass and Proptypes warning (firefox-devtools#4510)

(firefox-devtools#4350) Converted Step Button SVG's to images using CSS Styles (firefox-devtools#4502)

notify on failure (firefox-devtools#4511)

Fixes firefox-devtools#4505 - Convert file SVG to image (firefox-devtools#4514)

add terminology (firefox-devtools#4512)

* add terminology

* Update terminology.md

fix l10n label (firefox-devtools#4518)

Fix parser returning failing to clone data (firefox-devtools#4520)

debugging firefox

add a use-case for feature flags

Update local-development.md

Unselects highlight on search window close

Updates tests

Fixing Shortcut Modal Dark Theme Legibility on Mac

Move selected PrimaryTab local state to redux

Fix typo

another typo

Cleanup

Move selected PrimaryTab local state to redux

🐛: Use onKeyDown in SearchBar to allow for simpler iteration of results (firefox-devtools#4533)

In the QuickOpenModal we found that using onKeyDown meant a user could hold up/down to traverse
their results more easily. In the searchbar holding enter does the same.

Closes firefox-devtools#2527

removes declared hooks on componentWillUnmount (firefox-devtools#4426)

* removes declared hooks on componentWillUnmount

* changes listener binding from fat arrow to bind(this)

Style debuggee domain (firefox-devtools#4536)

🎨: Update our symbol parsing code to extract additional function types (firefox-devtools#4531)

Remove query strings when displaying call stack frames (firefox-devtools#4535)

[firefox-devtools#4545] Add tests for src/utils/assert.js (firefox-devtools#4546)

Fix filename for assert.js tests

Add tests for src/utils/log.js

Displays result count only after initiating search (firefox-devtools#4525)

Use new redux action in editor (firefox-devtools#4552)

Refactor waitForPaused

colon removed from subtitle

CI fix

show better error messages in jest (firefox-devtools#4558)

Add timing data (firefox-devtools#4540)

Refactor command action to use PROMISE (firefox-devtools#4554)

* Refactor waitForPaused

* Refactor command to be async

Release 10/25 (firefox-devtools#4493)

10-31 (firefox-devtools#4543)

updates readme 10/31

Update mochii to the latest version 🚀 (firefox-devtools#4562)

Refactor map scopes to fetch scopes (firefox-devtools#4550)

bump map-bindings (firefox-devtools#4566)

togglePaneCollapse update (firefox-devtools#4508)

Validate scripts (firefox-devtools#4565)

do not expand all scope objects (firefox-devtools#4498)

Update mochii to the latest version 🚀 (firefox-devtools#4576)

Fix conditional breakpoints (firefox-devtools#4465)

Update github-airtable-bridge to the latest version 🚀 (firefox-devtools#4578)

Dont show Mochi output for passing tests (firefox-devtools#4580)

Add airtable crm config (firefox-devtools#4582)

Add Unit Tests for Editor (firefox-devtools#4522)

Moves redux middleware to actions/utils (firefox-devtools#4567)

* Moves redux middleware to actions/utils

* Fixes import path in Jest

* Changes directory from actions/utils to actions/utils/middleware

* moves create-store from utils/middleware to utils

Fix jest intermittent - quick open

FIX - cmd+shift+b is no longer bound (firefox-devtools#4595)

* cmd+shift+b is no longer bound - Fix

* Fix2 - cmd+shift+b is no longer bound

* action fix - cmd+shift+b is no longer bound

Re-enable tests (firefox-devtools#4564)

Improve JSX syntax highlighting (firefox-devtools#4539)

Mochi intermittent script (firefox-devtools#4586)

Disallow uncaught exceptions (firefox-devtools#4584)

Optimistically clear pause state (firefox-devtools#4557)

Competing Scripts - break webpack (firefox-devtools#4606)

* Competing Scripts - break webpack

* Update most-common-issues.md

Fixes secondary pane css classes being localized (firefox-devtools#4611)

Preview mochitest (firefox-devtools#4603)

Panel fixes (firefox-devtools#4598)

Add some additional helper methods

Exclude flow types from identifier locations

Add a license header (firefox-devtools#4601)

Fix display of return value / thrown exception in scopes (firefox-devtools#4569)

Adds mk_add_options AUTOCLOBBER=1 to .mozconfig (firefox-devtools#4622)

Add launchpad screenshot (firefox-devtools#4623)

bump bindings (firefox-devtools#4625)

fix markdown lint (firefox-devtools#4626)

Upgrade flow (firefox-devtools#4591)

spell check docs (firefox-devtools#4627)

Fix flow ignore (firefox-devtools#4628)

flash function when it is copied - feature firefox-devtools#4022 (firefox-devtools#4634)

added flash action

Update mochii to the latest version 🚀 (firefox-devtools#4638)

Issue ADD_SCOPES even for wasm files. (firefox-devtools#4637)

Issue firefox-devtools#4639 - bump devtools-reps to 0.12.4

Issue firefox-devtools#4639 - update yarn.lock

Replaces Object.assign with ... spread (firefox-devtools#4574)

Re-enable wasm test (firefox-devtools#4644)

Release the debugger (firefox-devtools#4633)

* Bug 4420 fix

* tweaks

Add small lint fixes

Display more wast text lines (firefox-devtools#4648)

Relax findSource

Update mochitests.md

Breakpoint setting unit tests (firefox-devtools#4655)

* Breakpoint stepping unit tests

* Working Tests

Release (11-7) 2nd try (firefox-devtools#4670)

* skip quick open on windows

Drop react-immutable-proptypes (firefox-devtools#4667)

Fix Console Hang

Specify the ids of the jump and the add-watch-expression menuitems

initial commit

initial commit
khal0988 pushed a commit to khal0988/debugger.html that referenced this pull request Nov 12, 2017
jasonLaster pushed a commit to jasonLaster/debugger.html that referenced this pull request Nov 15, 2017
# Conflicts:
#	src/actions/sources/loadSourceText.js
#	src/components/Editor/index.js
jasonLaster pushed a commit to jasonLaster/debugger.html that referenced this pull request Nov 16, 2017
# Conflicts:
#	src/actions/sources/loadSourceText.js
#	src/actions/tests/ast.spec.js
#	src/components/Editor/index.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants