Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constant dimension #3344

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Fix constant dimension #3344

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8369e5
Fix constant array dimension error.
Ig-dolci Jan 22, 2024
21699d9
Update firedrake/adjoint_utils/constant.py
Ig-dolci Jan 22, 2024
c5fa1b2
Check that the constant has the correct dimension.
Ig-dolci Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion firedrake/adjoint_utils/constant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def _ad_copy(self):
return self._constant_from_values()

def _ad_dim(self):
return numpy.prod(self.dat.data_ro.cdim)
return numpy.prod(self.dat.data_ro.ndim)
dham marked this conversation as resolved.
Show resolved Hide resolved
Ig-dolci marked this conversation as resolved.
Show resolved Hide resolved

def _ad_imul(self, other):
self.assign(self._constant_from_values(self.dat.data_ro.reshape(-1) * other))
Expand Down