Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constant dimension #3344

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Fix constant dimension #3344

merged 3 commits into from
Jan 24, 2024

Conversation

Ig-dolci
Copy link
Contributor

Description

Fix constant array dimension error.

JDBetteridge
JDBetteridge previously requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@JDBetteridge JDBetteridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30% sure...

firedrake/adjoint_utils/constant.py Outdated Show resolved Hide resolved
@Ig-dolci Ig-dolci linked an issue Jan 22, 2024 that may be closed by this pull request
BUG: Error in UFLInequalityConstraint with ROL #3338
Closed
@Ig-dolci Ig-dolci marked this pull request as ready for review January 22, 2024 15:30
connorjward
connorjward reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a simple test of this? Even just a test which is "this code should not raise an exception" might be suitable.
Then discussions of "I think this is the right thing to do" can be validated.

@Ig-dolci Ig-dolci changed the title Fix constant array dimension error. Fix constant dimension Jan 24, 2024
@dham dham merged commit 7d21e31 into master Jan 24, 2024
10 checks passed
@dham dham deleted the dolci/fix_constant_array_dim branch January 24, 2024 16:49
Ig-dolci added a commit that referenced this pull request Jan 30, 2024
@Ig-dolci @JDBetteridge
Fix constant dimension (#3344)
677653f 
* Fix constant array dimension error.

Co-authored-by: Jack Betteridge <[email protected]>

* Check that the constant has the correct dimension.

---------

Co-authored-by: Jack Betteridge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjward connorjward connorjward left review comments

@dham dham dham approved these changes

@JDBetteridge JDBetteridge JDBetteridge left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Error in UFLInequalityConstraint with ROL
4 participants
@Ig-dolci @dham @connorjward @JDBetteridge