Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test-only API shim (Lite SDK) #3364

Merged
merged 6 commits into from
Jul 9, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

This PR adds the API shim that I am using to run the existing integration tests agains the tree-shakeable API. It essentially exposes the tree-shakeable client in terms of the old API.

Same logic as #3361

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2020

🦋 Changeset is good to go

Latest commit: 7eda0dd

We got this.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 7, 2020

Binary Size Report

Affected SDKs

  • @firebase/auth

    Type Base (064cf2e) Head (f2772b5) Diff
    main 177 kB 177 kB +137 B (+0.1%)
    module 177 kB 177 kB +137 B (+0.1%)
  • @firebase/firestore

    Type Base (064cf2e) Head (f2772b5) Diff
    browser 247 kB 247 kB +699 B (+0.3%)
    esm2017 193 kB 194 kB +303 B (+0.2%)
    main 494 kB 495 kB +1.27 kB (+0.3%)
    module 244 kB 245 kB +667 B (+0.3%)
    react-native 194 kB 194 kB +303 B (+0.2%)
  • @firebase/firestore/exp

    Type Base (064cf2e) Head (f2772b5) Diff
    main 398 kB 400 kB +1.74 kB (+0.4%)
  • @firebase/firestore/lite

    Type Base (064cf2e) Head (f2772b5) Diff
    main 124 kB 124 kB -73 B (-0.1%)
  • @firebase/firestore/memory

    Type Base (064cf2e) Head (f2772b5) Diff
    browser 184 kB 185 kB +385 B (+0.2%)
    esm2017 145 kB 145 kB +138 B (+0.1%)
    main 363 kB 364 kB +466 B (+0.1%)
    module 182 kB 183 kB +363 B (+0.2%)
    react-native 145 kB 145 kB +138 B (+0.1%)
  • @firebase/functions

    Type Base (064cf2e) Head (f2772b5) Diff
    browser 9.18 kB 9.64 kB +463 B (+5.0%)
    esm2017 7.01 kB 7.30 kB +285 B (+4.1%)
    main 9.21 kB 9.67 kB +463 B (+5.0%)
    module 9.00 kB 9.45 kB +451 B (+5.0%)
  • firebase

    Type Base (064cf2e) Head (f2772b5) Diff
    firebase-auth.js 173 kB 174 kB +133 B (+0.1%)
    firebase-firestore.js 285 kB 285 kB +657 B (+0.2%)
    firebase-firestore.memory.js 224 kB 224 kB +362 B (+0.2%)
    firebase-functions.js 9.60 kB 9.84 kB +242 B (+2.5%)
    firebase.js 818 kB 819 kB +1.04 kB (+0.1%)

Test Logs

}

export class FieldPath implements legacy.FieldPath {
private fieldNames: string[];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/private/private readonly

Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same minor/optional nits/questions as in #3361.

@schmidt-sebastian schmidt-sebastian merged commit 4fc68ef into master Jul 9, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/liteshim branch July 9, 2020 17:43
@firebase firebase locked and limited conversation to collaborators Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants