-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test-only API shim (Lite SDK) #3364
Conversation
🦋 Changeset is good to goLatest commit: 7eda0dd We got this. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs |
packages/firestore/lite/test/shim.ts
Outdated
} | ||
|
||
export class FieldPath implements legacy.FieldPath { | ||
private fieldNames: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/private/private readonly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same minor/optional nits/questions as in #3361.
This PR adds the API shim that I am using to run the existing integration tests agains the tree-shakeable API. It essentially exposes the tree-shakeable client in terms of the old API.
Same logic as #3361