Make UserDataReader tree-shakeable (#3333)

firebase · Jul 6, 2020 · 064cf2e · 064cf2e
1 parent c7aa053
commit 064cf2e
Show file tree

Hide file tree

Showing 11 changed files with 2,717 additions and 551 deletions.
diff --git a/.changeset/four-melons-laugh.md b/.changeset/four-melons-laugh.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/packages/firestore/exp/src/api/reference.ts b/packages/firestore/exp/src/api/reference.ts
@@ -22,15 +22,18 @@ import * as firestore from '../../index';
 import { Firestore } from './database';
 import {
   DocumentKeyReference,
-  ParsedUpdateData
+  ParsedUpdateData,
+  parseSetData,
+  parseUpdateData,
+  parseUpdateVarargs
 } from '../../../src/api/user_data_reader';
 import { debugAssert } from '../../../src/util/assert';
 import { cast } from '../../../lite/src/api/util';
 import { DocumentSnapshot, QuerySnapshot } from './snapshot';
 import {
   addDocSnapshotListener,
-  addSnapshotsInSyncListener,
   addQuerySnapshotListener,
+  addSnapshotsInSyncListener,
   applyFirestoreDataConverter,
   getDocsViaSnapshotListener,
   getDocViaSnapshotListener,
@@ -175,7 +178,8 @@ export function setDoc<T>(
     options
   );
   const dataReader = newUserDataReader(firestore);
-  const parsed = dataReader.parseSetData(
+  const parsed = parseSetData(
+    dataReader,
     'setDoc',
     ref._key,
     convertedValue,
@@ -215,15 +219,17 @@ export function updateDoc(
     typeof fieldOrUpdateData === 'string' ||
     fieldOrUpdateData instanceof FieldPath
   ) {
-    parsed = dataReader.parseUpdateVarargs(
+    parsed = parseUpdateVarargs(
+      dataReader,
       'updateDoc',
       ref._key,
       fieldOrUpdateData,
       value,
       moreFieldsAndValues
     );
   } else {
-    parsed = dataReader.parseUpdateData(
+    parsed = parseUpdateData(
+      dataReader,
       'updateDoc',
       ref._key,
       fieldOrUpdateData
@@ -262,11 +268,13 @@ export function addDoc<T>(
   const convertedValue = applyFirestoreDataConverter(collRef._converter, data);
 
   const dataReader = newUserDataReader(collRef.firestore);
-  const parsed = dataReader.parseSetData(
+  const parsed = parseSetData(
+    dataReader,
     'addDoc',
     docRef._key,
     convertedValue,
-    collRef._converter !== null
+    collRef._converter !== null,
+    {}
   );
 
   return firestore