Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UserDataReader tree-shakeable #3333

Merged
merged 9 commits into from
Jul 6, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jul 1, 2020

The idea is to not make setDoc() pull in the update-related code and vice versa.

Diff without whitespace: #3333

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 1, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (c7aa053) Head (c1e1c33) Diff
    browser 247 kB 247 kB -56 B (-0.0%)
    esm2017 193 kB 193 kB +32 B (+0.0%)
    main 494 kB 494 kB -4 B (-0.0%)
    module 244 kB 244 kB -56 B (-0.0%)
    react-native 194 kB 194 kB +32 B (+0.0%)
  • @firebase/firestore/exp

    Type Base (c7aa053) Head (c1e1c33) Diff
    main 398 kB 398 kB +139 B (+0.0%)
  • @firebase/firestore/lite

    Type Base (c7aa053) Head (c1e1c33) Diff
    main 124 kB 124 kB +136 B (+0.1%)
  • @firebase/firestore/memory

    Type Base (c7aa053) Head (c1e1c33) Diff
    browser 184 kB 184 kB -56 B (-0.0%)
    esm2017 145 kB 145 kB +32 B (+0.0%)
    main 363 kB 363 kB -4 B (-0.0%)
    module 183 kB 182 kB -56 B (-0.0%)
    react-native 145 kB 145 kB +32 B (+0.0%)
  • firebase

    Type Base (c7aa053) Head (c1e1c33) Diff
    firebase-firestore.js 285 kB 285 kB -59 B (-0.0%)
    firebase-firestore.memory.js 224 kB 224 kB -59 B (-0.0%)
    firebase.js 818 kB 818 kB -59 B (-0.0%)

Test Logs

Copy link
Contributor

@rafikhan rafikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2020

🦋 Changeset is good to go

Latest commit: d0cb52b

We got this.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@schmidt-sebastian schmidt-sebastian changed the base branch from mrschmidt/mutations2 to master July 6, 2020 22:08
@schmidt-sebastian schmidt-sebastian merged commit 064cf2e into master Jul 6, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/userdatareader2 branch July 9, 2020 17:44
@firebase firebase locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants