Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Match Firebase 10 implementation in WKNavigationDelegate conformance #13714

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Sep 24, 2024

While testing #13634, found one behavior regression that led to reCATPCHA not working on macCatalyst.

Steps to repro:

  1. Build Auth sample for macCatalyst (requires some disabling of code to get build green, and enabling Catalyst support)
  2. Phone number flow, add phone #, verify
  3. A blank screen will be presented

With this PR, the reCAPTCHA flow will be presented instead of a blank screen.

In v10, allow was always returned:

decisionHandler(WKNavigationActionPolicyAllow);

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

decisionHandler(WKNavigationActionPolicyAllow);

@ncooke3 ncooke3 marked this pull request as ready for review September 24, 2024 19:31
@ncooke3 ncooke3 merged commit 335f3d2 into main Sep 24, 2024
46 of 47 checks passed
@ncooke3 ncooke3 deleted the nc/auth-webview branch September 24, 2024 19:34
@firebase firebase locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants