[Infra] Fix warning in Auth's AuthWebViewController.swift #13634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in this PR is only used on macCatalyst, so it will not have an effect on #13645 (I'll look into that separately though). FYI, I'm waiting on a profile to test this PR with (need a new one for mac builds). |
|
Updated description with confirmed testing. |
This was referenced Sep 24, 2024
andrewheard
pushed a commit
that referenced
this pull request
Sep 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually tested via macCatalyst (see below comment as to why) and confirmed that delegate gets triggered in both a macCatalyst app built with Xcode 15 and an app built with Xcode 16.
Fix #13507
This appears to avoif the
#ifs needed in this workaround.#no-changelog