Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Clean up visionOS conditionals #12934

Merged
merged 1 commit into from
May 10, 2024
Merged

[Infra] Clean up visionOS conditionals #12934

merged 1 commit into from
May 10, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 10, 2024 •
edited
Loading 

➜  firebase git:(main) find /Applications/Xcode_15.2.app -name TargetConditionals.h | xargs grep -l TARGET_OS_VISION | wc -l 
      13
➜  firebase git:(main) find /Applications/Xcode_15.2.app -name TargetConditionals.h | wc -l
      13

#no-changelog

paulb777
paulb777 approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green. Thanks!

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from ? (d9f9382) to 53.73% (bdb542f) by ?.

    105 individual files with coverage change

    FilenameBase (d9f9382)Merge (bdb542f)Diff
    APLevelDB.mm?61.30%?
    DatabaseReference+WriteEncodable.swift?0.00%?
    DataSnapshot+ReadDecodable.swift?0.00%?
    FAckUserWrite.m?83.33%?
    FArraySortedDictionary.m?97.49%?
    FAtomicNumber.m?100.00%?
    fbase64.c?31.20%?
    FCacheNode.m?100.00%?
    FCachePolicy.m?17.14%?
    FCancelEvent.m?0.00%?
    FChange.m?88.24%?
    FChildChangeAccumulator.m?65.22%?
    FChildEventRegistration.m?0.00%?
    FChildrenNode.m?91.16%?
    FClock.m?100.00%?
    FCompoundHash.m?97.70%?
    FCompoundWrite.m?91.12%?
    FConnection.m?26.81%?
    FDataEvent.m?29.41%?
    FEmptyNode.m?100.00%?
    FEventEmitter.m?0.00%?
    FEventGenerator.m?95.37%?
    FEventRaiser.m?33.33%?
    FImmutableSortedDictionary.m?31.03%?
    FImmutableSortedSet.m?54.22%?
    FImmutableTree.m?85.75%?
    FIndex.m?91.67%?
    FIndexedFilter.m?96.38%?
    FIndexedNode.m?97.06%?
    FIRDatabase.m?15.76%?
    FIRDatabaseComponent.m?19.23%?
    FIRDatabaseConfig.m?59.62%?
    FIRDatabaseConnectionContextProvider.m?96.67%?
    FIRDatabaseQuery.m?3.86%?
    FIRDatabaseReference.m?6.41%?
    FIRDataSnapshot.m?89.71%?
    FIRMutableData.m?75.51%?
    FIRRetryHelper.m?83.33%?
    FIRServerValue.m?0.00%?
    FIRTransactionResult.m?0.00%?
    FKeepSyncedEventRegistration.m?0.00%?
    FKeyIndex.m?60.56%?
    FLeafNode.m?86.98%?
    FLevelDBStorageEngine.m?71.37%?
    FLimitedFilter.m?97.25%?
    FListenComplete.m?0.00%?
    FLLRBEmptyNode.m?75.00%?
    FLLRBValueNode.m?85.39%?
    FMaxNode.m?60.61%?
    FMerge.m?87.18%?
    FNamedNode.m?62.32%?
    FNextPushId.m?62.50%?
    FOperationSource.m?89.29%?
    FOverwrite.m?81.48%?
    FPath.m?94.30%?
    FPathIndex.m?88.75%?
    FPendingPut.m?0.00%?
    FPersistenceManager.m?55.19%?
    FPersistentConnection.m?21.28%?
    FPriorityIndex.m?87.84%?
    FPruneForest.m?93.08%?
    FQueryParams.m?96.24%?
    FQuerySpec.m?86.36%?
    FRangedFilter.m?93.67%?
    FRangeMerge.m?94.06%?
    FRepo.m?13.49%?
    FRepoInfo.m?73.00%?
    FRepoManager.m?29.86%?
    FServerValues.m?50.85%?
    FSnapshotHolder.m?100.00%?
    FSnapshotUtilities.m?62.06%?
    FSparseSnapshotTree.m?98.13%?
    FSRWebSocket.m?0.00%?
    FStringUtilities.m?79.41%?
    FSyncPoint.m?87.80%?
    FSyncTree.m?71.33%?
    FTrackedQuery.m?75.38%?
    FTrackedQueryManager.m?90.50%?
    FTransformedEnumerator.m?100.00%?
    FTree.m?6.04%?
    FTreeNode.m?100.00%?
    FTreeSortedDictionary.m?96.17%?
    FTreeSortedDictionaryEnumerator.m?100.00%?
    FTupleNodePath.m?0.00%?
    FTupleObjectNode.m?0.00%?
    FTuplePathValue.m?100.00%?
    FTupleRemovedQueriesEvents.m?100.00%?
    FTupleSetIdPath.m?0.00%?
    FTupleStringNode.m?0.00%?
    FTupleTransaction.m?0.00%?
    FTupleUserCallback.m?0.00%?
    FUtilities.m?74.01%?
    FValidation.m?25.32%?
    FValueEventRegistration.m?0.00%?
    FValueIndex.m?48.53%?
    FView.m?80.11%?
    FViewCache.m?100.00%?
    FViewProcessor.m?91.87%?
    FViewProcessorResult.m?100.00%?
    FWebSocketConnection.m?35.00%?
    FWriteRecord.m?45.65%?
    FWriteTree.m?75.44%?
    FWriteTreeRef.m?100.00%?
    NSData+SRB64Additions.m?81.82%?
    ServerTimestamp.swift?0.00%?

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.18% (d9f9382) to 88.10% (bdb542f) by -0.08%.

    FilenameBase (d9f9382)Merge (bdb542f)Diff
    connectivity_monitor_apple.mm52.83%51.92%-0.91%
    exception.cc84.21%23.68%-60.53%
    filesystem_apple.mm86.49%86.30%-0.19%
    grpc_stream.cc99.01%98.02%-0.99%
    leveldb_key.cc98.63%98.82%+0.20%
    leveldb_opener.cc78.99%77.54%-1.45%
    leveldb_remote_document_cache.cc94.83%96.55%+1.72%
    ordered_code.cc93.90%94.39%+0.49%

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 60.19% (d9f9382) to 59.96% (bdb542f) by -0.23%.

    FilenameBase (d9f9382)Merge (bdb542f)Diff
    FIRMessaging.m55.20%53.97%-1.23%
    FIRMessagingBackupExcludedPlist.m82.09%85.07%+2.99%
    FIRMessagingTokenManager.m14.82%14.24%-0.59%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/S2kWGw21jg.html

andrewheard
andrewheard approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nick! It looks like the failing CI jobs are using macos-12 (i.e., where Xcode 15.2+ isn't available). If they're easy to migrate this will be a very nice cleanup!

@ncooke3 ncooke3 mentioned this pull request May 10, 2024
Merged
@ncooke3 ncooke3 closed this May 10, 2024
@ncooke3 ncooke3 reopened this May 10, 2024
@ncooke3
Copy link
Member Author

ncooke3 commented May 10, 2024

Restart CI after #12938 merged.

@ncooke3 ncooke3 merged commit 554255a into main May 10, 2024
287 of 293 checks passed
@ncooke3 ncooke3 deleted the nc/visionos branch May 10, 2024 20:18
@firebase firebase locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: core api: database api: firestore api: inappmessaging Firebase In App Messaging api: messaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncooke3 @google-oss-bot @paulb777 @andrewheard