Skip to content

Commit

Permalink
Merge dfa00a6 into d9f9382
Browse files Browse the repository at this point in the history
  • Loading branch information
ncooke3 authored May 10, 2024
2 parents d9f9382 + dfa00a6 commit bdb542f
Show file tree
Hide file tree
Showing 48 changed files with 91 additions and 103 deletions.
2 changes: 1 addition & 1 deletion FirebaseCore/Sources/FIRApp.m
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,7 @@ + (void)registerSwiftComponents {
#pragma mark - App Life Cycle

- (void)subscribeForAppDidBecomeActiveNotifications {
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
NSNotificationName notificationName = UIApplicationDidBecomeActiveNotification;
#elif TARGET_OS_OSX
NSNotificationName notificationName = NSApplicationDidBecomeActiveNotification;
Expand Down
2 changes: 1 addition & 1 deletion FirebaseCore/Tests/Unit/FIRAppTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,7 @@ - (XCTestExpectation *)expectNotificationNamed:(NSNotificationName)name
}

- (NSNotificationName)appDidBecomeActiveNotificationName {
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
return UIApplicationDidBecomeActiveNotification;
#elif TARGET_OS_OSX
return NSApplicationDidBecomeActiveNotification;
Expand Down
3 changes: 1 addition & 2 deletions FirebaseDatabase/Sources/Core/FPersistentConnection.m
Original file line number Diff line number Diff line change
Expand Up @@ -1256,8 +1256,7 @@ - (void)sendStats:(NSDictionary *)stats {
- (void)sendConnectStats {
NSMutableDictionary *stats = [NSMutableDictionary dictionary];

#if TARGET_OS_IOS || TARGET_OS_TV || \
(defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
if (self.config.persistenceEnabled) {
stats[@"persistence.ios.enabled"] = @1;
}
Expand Down
6 changes: 2 additions & 4 deletions FirebaseDatabase/Sources/Core/FRepo.m
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@
#import "FirebaseDatabase/Sources/Utilities/Tuples/FTupleTransaction.h"
#import <dlfcn.h>

#if TARGET_OS_IOS || TARGET_OS_TV || \
(defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
#import <UIKit/UIKit.h>
#endif

Expand Down Expand Up @@ -816,8 +815,7 @@ - (void)didEnterBackground {

// Targetted compilation is ONLY for testing. UIKit is weak-linked in actual
// release build.
#if TARGET_OS_IOS || TARGET_OS_TV || \
(defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
// The idea is to wait until any outstanding sets get written to disk. Since
// the sets might still be in our dispatch queue, we wait for the dispatch
// queue to catch up and for persistence to catch up. This may be
Expand Down
3 changes: 1 addition & 2 deletions FirebaseDatabase/Sources/Persistence/FLevelDBStorageEngine.m
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,7 @@ - (void)close {
}

+ (NSString *)firebaseDir {
#if TARGET_OS_IOS || TARGET_OS_WATCH || \
(defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_WATCH || TARGET_OS_VISION
NSArray *dirPaths = NSSearchPathForDirectoriesInDomains(
NSDocumentDirectory, NSUserDomainMask, YES);
NSString *documentsDir = [dirPaths objectAtIndex:0];
Expand Down
3 changes: 1 addition & 2 deletions FirebaseDatabase/Sources/Realtime/FWebSocketConnection.m
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ - (NSString *)userAgent {

// Targetted compilation is ONLY for testing. UIKit is weak-linked in actual
// release build.
#if TARGET_OS_IOS || TARGET_OS_TV || \
(defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Class uiDeviceClass = NSClassFromString(@"UIDevice");
if (uiDeviceClass) {
systemVersion = [uiDeviceClass currentDevice].systemVersion;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import <GoogleUtilities/GULUserDefaults.h>

Expand Down Expand Up @@ -176,4 +176,4 @@ - (void)logAnalyticsEventForType:(FIRIAMAnalyticsLogEventType)eventType
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseCore/Extension/FirebaseCoreInternal.h"

Expand Down Expand Up @@ -204,4 +204,4 @@ - (void)sendClearcutHttpRequestForLogs:(NSArray<FIRIAMClearcutLogRecord *> *)log
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import <UIKit/UIKit.h>

Expand Down Expand Up @@ -209,4 +209,4 @@ - (BOOL)saveIntoCacheWithPath:(NSString *)cacheFilePath {
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseCore/Extension/FirebaseCoreInternal.h"

Expand Down Expand Up @@ -214,4 +214,4 @@ - (void)logAnalyticsEventForType:(FIRIAMAnalyticsLogEventType)eventType
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import <GoogleUtilities/GULUserDefaults.h>
#import <UIKit/UIKit.h>
Expand Down Expand Up @@ -246,4 +246,4 @@ - (void)scheduleNextSend {

@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseCore/Extension/FirebaseCoreInternal.h"

Expand Down Expand Up @@ -399,4 +399,4 @@ - (NSString *)sanitizedURLStringFromString:(NSString *)string {

@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseCore/Extension/FirebaseCoreInternal.h"

Expand Down Expand Up @@ -206,4 +206,4 @@ - (void)fetchImageFromURL:(NSURL *)imageURL

@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
4 changes: 2 additions & 2 deletions FirebaseInAppMessaging/Sources/Data/FIRIAMMessageDefinition.m
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseInAppMessaging/Sources/Private/Data/FIRIAMMessageDefinition.h"

Expand Down Expand Up @@ -109,4 +109,4 @@ - (BOOL)messageHasStarted {
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseInAppMessaging/Sources/Private/Data/FIRIAMRenderingEffectSetting.h"

Expand All @@ -34,4 +34,4 @@ + (instancetype)getDefaultRenderingEffectSetting {
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseInAppMessaging/Sources/Private/DisplayTrigger/FIRIAMDisplayTriggerDefinition.h"

Expand Down Expand Up @@ -43,4 +43,4 @@ - (instancetype)initWithFirebaseAnalyticEvent:(NSString *)title {
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
4 changes: 2 additions & 2 deletions FirebaseInAppMessaging/Sources/FIRCore+InAppMessaging.m
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import <Foundation/Foundation.h>
#import "FirebaseInAppMessaging/Sources/FIRCore+InAppMessaging.h"

NSString *const kFirebaseInAppMessagingErrorDomain = @"com.firebase.inappmessaging";
FIRLoggerService kFIRLoggerInAppMessaging = @"[FirebaseInAppMessaging]";

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
4 changes: 2 additions & 2 deletions FirebaseInAppMessaging/Sources/FIRInAppMessaging.m
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseInAppMessaging/Sources/Public/FirebaseInAppMessaging/FIRInAppMessaging.h"

Expand Down Expand Up @@ -145,4 +145,4 @@ - (void)triggerEvent:(NSString *)eventName {

@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
4 changes: 2 additions & 2 deletions FirebaseInAppMessaging/Sources/Flows/FIRIAMActivityLogger.m
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import <UIKit/UIKit.h>

Expand Down Expand Up @@ -245,4 +245,4 @@ - (void)addLogRecord:(FIRIAMActivityRecord *)newRecord {
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
4 changes: 2 additions & 2 deletions FirebaseInAppMessaging/Sources/Flows/FIRIAMBookKeeper.m
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import <GoogleUtilities/GULUserDefaults.h>

Expand Down Expand Up @@ -264,4 +264,4 @@ - (void)cleanupFetchRecords {
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
#import "FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h"
Expand Down Expand Up @@ -133,4 +133,4 @@ - (NSString *)getIAMSDKVersion {
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
#import "Interop/Analytics/Public/FIRAnalyticsInterop.h"
Expand Down Expand Up @@ -68,4 +68,4 @@ - (void)stop {

@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseCore/Extension/FirebaseCoreInternal.h"

Expand Down Expand Up @@ -67,4 +67,4 @@ - (void)dealloc {
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseCore/Extension/FirebaseCoreInternal.h"

Expand Down Expand Up @@ -64,4 +64,4 @@ - (void)dealloc {
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseInAppMessaging/Sources/Private/Flows/FIRIAMDisplayCheckTriggerFlow.h"

Expand All @@ -34,4 +34,4 @@ - (void)stop {
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
4 changes: 2 additions & 2 deletions FirebaseInAppMessaging/Sources/Flows/FIRIAMDisplayExecutor.m
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import <UIKit/UIKit.h>
#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
Expand Down Expand Up @@ -778,4 +778,4 @@ - (void)checkAndDisplayNextAppForegroundMessage {
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
4 changes: 2 additions & 2 deletions FirebaseInAppMessaging/Sources/Flows/FIRIAMFetchFlow.m
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseCore/Extension/FirebaseCoreInternal.h"

Expand Down Expand Up @@ -267,4 +267,4 @@ - (void)checkForAppLaunchMessage {
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <TargetConditionals.h>
#if TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION

#import "FirebaseCore/Extension/FirebaseCoreInternal.h"

Expand Down Expand Up @@ -61,4 +61,4 @@ - (void)dealloc {
}
@end

#endif // TARGET_OS_IOS || TARGET_OS_TV || (defined(TARGET_OS_VISION) && TARGET_OS_VISION)
#endif // TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
Loading

0 comments on commit bdb542f

Please sign in to comment.