Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TypeScript dependency to v3.8 to fix build issues (Issue #667) #668

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Update TypeScript dependency to v3.8 to fix build issues (Issue #667) #668

merged 2 commits into from
Apr 24, 2020

Conversation

laurenzlong
Copy link
Contributor

Description

Fix #667 and #647

Code sample

@laurenzlong laurenzlong requested a review from joehan April 24, 2020 00:59
@laurenzlong laurenzlong mentioned this pull request Apr 24, 2020
Closed
@laurenzlong laurenzlong changed the title Update TypeScript dependency to v.3.8 to fix build issues (Issue #667) Update TypeScript dependency to v3.8 to fix build issues (Issue #667) Apr 24, 2020
joehan
joehan approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurenzlong laurenzlong merged commit 2784d5d into master Apr 24, 2020
@laurenzlong laurenzlong deleted the ll-updatets branch April 24, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehan joehan joehan approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An accessor cannot be declared in an ambient context.
3 participants
@laurenzlong @joehan @googlebot