Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript 3.7 is required while package.json points to 3.5 #647

Closed
dotdoom opened this issue Mar 28, 2020 · 2 comments
Closed

TypeScript 3.7 is required while package.json points to 3.5 #647

dotdoom opened this issue Mar 28, 2020 · 2 comments
Assignees

Comments

@dotdoom
Copy link

dotdoom commented Mar 28, 2020

[REQUIRED] Version info

node:
v8.17.0

firebase-functions:
3.5.0

firebase-tools:
None

firebase-admin:
None

[REQUIRED] Test case

$ mkdir typescript-version
$ cd typescript-version
$ npm install firebase-functions [email protected]
$ echo "import * as functions from 'firebase-functions';" > index.ts
$ node_modules/.bin/tsc --init
$ node_modules/.bin/tsc -p .

[REQUIRED] Steps to reproduce

See above.

[REQUIRED] Expected behavior

Either typescript install fails, or tsc passes.

[REQUIRED] Actual behavior

Found 32 errors.

@google-oss-bot
Copy link
Collaborator

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@laurenzlong
Copy link
Contributor

This has been fixed in v3.6.1. Thanks fo reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants