Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap v2 firestore functions with trace context #1440

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Wrap v2 firestore functions with trace context #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
714aa66
Wrap v2 firestore functions with trace context
milo- Jul 11, 2023
10cc226
Add changelog
milo- Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- Add features to task queue functions. (#1423)
- Add traces to V2 Firestore trigger logs. (#1440)
3 changes: 2 additions & 1 deletion src/v2/providers/firestore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import {
createSnapshotFromJson,
createSnapshotFromProtobuf,
} from "../../common/providers/firestore";
import { wrapTraceContext } from "../trace";

export { Change };

Expand Down Expand Up @@ -445,7 +446,7 @@ export function onOperation<Document extends string>(
const event = raw as RawFirestoreEvent;
const params = makeParams(event.document, documentPattern) as unknown as ParamsOf<Document>;
const firestoreEvent = makeFirestoreEvent(eventType, event, params);
return handler(firestoreEvent);
return wrapTraceContext(handler)(firestoreEvent);
};

func.run = handler;
Expand Down