Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap v2 firestore functions with trace context #1440

Merged

Conversation

milo-
Copy link
Contributor

@milo- milo- commented Jul 11, 2023

Description

Wrap handlers with trace context. Fixes #1439

@blidd-google blidd-google self-requested a review July 11, 2023 21:08
Copy link
Contributor

@blidd-google blidd-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please update the changelog before merging changes.

@milo-
Copy link
Contributor Author

milo- commented Jul 11, 2023

Thanks @blidd-google, changelog added

@milo- milo- requested a review from blidd-google July 12, 2023 06:44
Copy link
Contributor

@blidd-google blidd-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@blidd-google blidd-google merged commit 41d616f into firebase:master Jul 13, 2023
@milo- milo- deleted the bugfix/wrap-v2-firestore-functions branch July 19, 2023 18:37
@lox
Copy link

lox commented Aug 5, 2023

Might it be possible to get this released?

@tonylampada
Copy link

Is there a way I can import and use the wrap handler myself while this doesn't get released?

@milo-
Copy link
Contributor Author

milo- commented Sep 10, 2023

@blidd-google Would it be possible to get this released? It would massively help debugging.

@ciriousjoker
Copy link

ciriousjoker commented Nov 3, 2023

@blidd-google It's been almost 4 months since you merged this, is there an eta for when this is released? Seems like #1331 is also blocked by this.

Nevermind, just realized there was an update to v4.5.0 17 hours ago which includes this lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firestore Cloud functions V2 are missing a trace in logs
5 participants