-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fis): Adding the admin.installations() API for deleting Firebase installation IDs #1187
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fa99ce9
feat(fis): Added admin.installations() API
hiranya911 9e4dd53
fix: Marked IID APIs deprecated
hiranya911 cdeb917
fix: Deprecated App.instanceId() method; Added more unit and integrat…
hiranya911 8fdb00c
fix: Throwing FirebaseInstallationsError from constructor
hiranya911 c936e3e
fix: Some docs updates
hiranya911 54ed99e
fix: Minor update to API doc comment
hiranya911 de6079a
Merge branch 'master' into hkj-fis
hiranya911 649b5d5
fix: Added Installations class to API ref toc
hiranya911 7193f0e
fix: Minor doc updates
hiranya911 ebc6dfa
Merge branch 'master' into hkj-fis
hiranya911 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
/*! | ||
* Copyright 2021 Google Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { app } from '../firebase-namespace-api'; | ||
|
||
/** | ||
* Gets the {@link installations.Installations `Installations`} service for the | ||
* default app or a given app. | ||
* | ||
* `admin.installations()` can be called with no arguments to access the default | ||
* app's {@link installations.Installations `Installations`} service or as | ||
* `admin.installations(app)` to access the | ||
* {@link installations.Installations `Installations`} service associated with a | ||
* specific app. | ||
* | ||
* @example | ||
* ```javascript | ||
* // Get the Installations service for the default app | ||
* var defaultInstallations = admin.installations(); | ||
* ``` | ||
* | ||
* @example | ||
* ```javascript | ||
* // Get the Installations service for a given app | ||
* var otherInstallations = admin.installations(otherApp); | ||
*``` | ||
* | ||
* @param app Optional app whose `Installations` service to | ||
* return. If not provided, the default `Installations` service is | ||
* returned. | ||
hiranya911 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* | ||
* @return The default `Installations` service if | ||
* no app is provided or the `Installations` service associated with the | ||
* provided app. | ||
*/ | ||
export declare function installations(app?: app.App): installations.Installations; | ||
|
||
/* eslint-disable @typescript-eslint/no-namespace */ | ||
export namespace installations { | ||
/** | ||
* Gets the {@link Installations `Installations`} service for the | ||
* current app. | ||
* | ||
* @example | ||
* ```javascript | ||
* var installations = app.installations(); | ||
* // The above is shorthand for: | ||
* // var installations = admin.installations(app); | ||
* ``` | ||
* | ||
* @return The `Installations` service for the | ||
* current app. | ||
*/ | ||
export interface Installations { | ||
app: app.App; | ||
|
||
/** | ||
* Deletes the specified installation ID and the associated data from Firebase. | ||
* | ||
* Note that Google Analytics for Firebase uses its own form of Instance ID to | ||
* keep track of analytics data. Therefore deleting a Firebase installation ID does | ||
* not delete Analytics data. See | ||
* [Delete a Firebase installation](/docs/projects/manage-installations#delete-installation) | ||
* for more information. | ||
* | ||
* @param fid The Firebase installation ID to be deleted. | ||
* | ||
* @return A promise fulfilled when the installation ID is deleted. | ||
*/ | ||
deleteInstallation(fid: string): Promise<void>; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible to add a "status: deprecated" flag here to create this kind of effect:
https://firebase.google.com/docs/reference/android/com/google/firebase/iid/package-summary?hl=en
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does that look like in the yaml? Can you point me to an example?