feat(fis): Adding the admin.installations() API for deleting Firebase installation IDs #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
approved these changes
Mar 10, 2021
egilmorez
reviewed
Mar 17, 2021
|
Thanks @egilmorez. I've responded to your comments. PTAL. |
avolkovi
approved these changes
Apr 12, 2021
egilmorez
reviewed
Apr 30, 2021
| section: | ||
| - title: "Installations" | ||
| path: /docs/reference/admin/node/admin.installations.Installations-1 | ||
|
|
||
| - title: "admin.instanceId" |
There was a problem hiding this comment.
It's possible to add a "status: deprecated" flag here to create this kind of effect:
https://firebase.google.com/docs/reference/android/com/google/firebase/iid/package-summary?hl=en
There was a problem hiding this comment.
What does that look like in the yaml? Can you point me to an example?
src/installations/index.ts
Outdated
| *``` | ||
| * | ||
| * @param app Optional app whose `Installations` service to | ||
| * return. If not provided, the default `Installations` service will be |
There was a problem hiding this comment.
"Optional app whose Installations service to
- return." makes sense but isn't 100% grammatical.
"Optional app for which to return the Installations service" is valid but not great.
"Optional app whose Installations service should be
- returned." sounds better, but "should" seems weak.
I'll poll the tech writers and see who has a solution :)
This was referenced Jul 17, 2024
This was referenced Jul 27, 2024
This was referenced Aug 10, 2024
This was referenced Aug 17, 2024
This was referenced Aug 28, 2024
This was referenced Sep 24, 2024
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admin.installations()API.admin.instanceId()API. The implementation of this API now just invokes the installations API under the hood.admin.instanceId()retains backward compatibility by converting theFirebaseInstallationsErrorraised by the new implementation to the oldFirebaseInstanceIdErrortype. Error codes are the same, but the error message may defer.go/firebase-admin-fis
RELEASE NOTE: Added a new
admin.installations()API to replace the existingadmin.instanceId()API. Developers are advised to migrate to the new API for deleting Firebase instance IDs and installation IDs.