Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rc): Fix Version update time parsing failure #1089

Merged
merged 2 commits into from
Nov 13, 2020
Merged

fix(rc): Fix Version update time parsing failure #1089

merged 2 commits into from
Nov 13, 2020

Conversation

lahirumaramba
Copy link
Member

  • Current check for update time fails for timestamps with more than 3 milliseconds places. Updated the timestamp validation logic as a quick fix.

Resolves: #1088

@lahirumaramba lahirumaramba added the release:stage Stage a release candidate label Nov 13, 2020
@lahirumaramba
Copy link
Member Author

  • Tested with both 3 and 6 milliseconds places in timestamps (updated unit tests)
  • Added release:stage to trigger integration tests

lahirumaramba
lahirumaramba commented Nov 13, 2020
View reviewed changes
src/remote-config/remote-config.ts
@@ -394,4 +390,8 @@ class VersionImpl implements Version {
updateTime: this.updateTime,
}
}

private isValidTimestamp(timestamp: string): boolean {
return validator.isNonEmptyString(timestamp) && (new Date(timestamp)).getTime() > 0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This validation fails for timestamps before January 1, 1970 and considers strings such as "1.2" as valid timestamps. I think that would be okay for this particular scenario. Open to suggestions!

hiranya911
hiranya911 approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd recommend adding another test case for getTemplate() so that both old and new date formats get tested.

@lahirumaramba lahirumaramba merged commit 2781eff into master Nov 13, 2020
@lahirumaramba lahirumaramba deleted the lm-rc-fix-updatetime branch November 13, 2020 21:07
BorntraegerMarc pushed a commit to BorntraegerMarc/firebase-admin-node that referenced this pull request Jan 28, 2021
@lahirumaramba @BorntraegerMarc
fix(rc): Fix Version update time parsing failure (firebase#1089)
e15a787 
* fix(rc): Fix Version update time parsing failure

* Add test cases for 3 and 6 ms places
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@lahirumaramba lahirumaramba

Labels
release:stage Stage a release candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firebase remote config get template api fails throws "Version update time must be a valid date string"
2 participants
@lahirumaramba @hiranya911