firebase remote config get template api fails throws "Version update time must be a valid date string" #1088

arshedg · 2020-11-13T08:39:12Z

Issue is reproducible in Firebase cloud function and in the local cloud function simulator(started occurring from 13-nov-2020)

Firebase SDK version: 9.4.0
Firebase Product: remote config
Node.js version: 10.10.0

Firebase node admin api "admin.remoteConfig().getTemplate() or config.getTemplateAtVersion" throws error

{"code":"remote-config/invalid-argument","message":"Version update time must be a valid date string"}

The issue is reproducible for all remote config versions updated today(using firebase ui or rest api).
Older remote config versions can be fetched.

config.getTemplateAtVersion(today's version) -> fails
config.getTemplateAtVersion(yesterday or previous version) -> works

Steps to reproduce:

update a remote config api using firebase ui.
get the template using the admin api

additional information

The version details of today's config(which doesn't work) look like

{
  "versionNumber": "7771",
  "updateTime": "2020-11-13T08:02:12.468168Z",
.....
}

Version details of old remote config (which work)

{
  "versionNumber": "7740",
  "updateTime": "2020-11-12T14:53:52.351Z",
...

You can see the time format is different for new and old remote config. I guess that's the reason why api is failing

The text was updated successfully, but these errors were encountered:

google-oss-bot · 2020-11-13T08:39:13Z

I found a few problems with this issue:

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
This issue does not seem to follow the issue template. Make sure you provide all the required information.

sulayyudiz · 2020-11-13T10:45:59Z

I am also facing the same issue

whereissami · 2020-11-13T12:12:08Z

Experiencing same issue cant get remote config values in my cloud functions.

evilass · 2020-11-13T12:17:00Z

We also facing this one since today.

fkneist · 2020-11-13T12:58:21Z

Same here

WiNloSt · 2020-11-13T13:55:27Z

I'm also facing the same problem, I've debugging like crazy the past few hours until I found this issue.

For me, the parameter was added no longer than the past few hours. And the command

admin.remoteConfig().getTemplate()

Will fail with the same error described in the issue.

I've also tried downgrading firebase-admin to version 9.2.0, and 9.0.0 but doesn't really help.

VGJohn · 2020-11-13T16:32:26Z

Seeing this issue today as well

ryanoboril · 2020-11-13T16:43:12Z

Same here, issue appeared overnight with no code changes or even npm update

lukencrocker · 2020-11-13T17:29:50Z

Same issue here. Appeared overnight with no code changes. Tried all I can think of but still fails when hitting this line "admin.remoteConfig().getTemplate();" Only thing I did for it to start failing is add a new Remote Config setting as described.

moshaheen · 2020-11-13T17:57:17Z

Happening to us as well. just started today

pedr0ni · 2020-11-13T18:35:51Z

Same issue here.

Stack trace:

PrefixedFirebaseError: Version update time must be a valid date string
at FirebaseRemoteConfigError.FirebaseError [as constructor] (/Users/matheusr/Documents/B2B/platform-config/mobile/firebase-autosync/node_modules/firebase-admin/lib/utils/error.js:43:28)
at FirebaseRemoteConfigError.PrefixedFirebaseError [as constructor] (/Users/matheusr/Documents/B2B/platform-config/mobile/firebase-autosync/node_modules/firebase-admin/lib/utils/error.js:89:28)
at new FirebaseRemoteConfigError (/Users/matheusr/Documents/B2B/platform-config/mobile/firebase-autosync/node_modules/firebase-admin/lib/remote-config/remote-config-api-client-internal.js:403:23)
at new VersionImpl (/Users/matheusr/Documents/B2B/platform-config/mobile/firebase-autosync/node_modules/firebase-admin/lib/remote-config/remote-config.js:297:23)
at new RemoteConfigTemplateImpl (/Users/matheusr/Documents/B2B/platform-config/mobile/firebase-autosync/node_modules/firebase-admin/lib/remote-config/remote-config.js:208:28)
at /Users/matheusr/Documents/B2B/platform-config/mobile/firebase-autosync/node_modules/firebase-admin/lib/remote-config/remote-config.js:61:20
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at async getConfig (/Users/matheusr/Documents/B2B/platform-config/mobile/firebase-autosync/index.js:21:12)
at async main (/Users/matheusr/Documents/B2B/platform-config/mobile/firebase-autosync/index.js:48:28) {
errorInfo: {
code: 'remote-config/invalid-argument',
message: 'Version update time must be a valid date string'
},
codePrefix: 'remote-config'
}

leonardoj-cit · 2020-11-13T18:54:55Z

I noticed that the problem seems to be related to the number of places used for the milliseconds
This is the version time that is being returned for me 2020-11-13T18:30:14.543720Z, for a valid ISO it should be just 3 instead of 6 before the Z, so 2020-11-13T18:30:14.543Z

The code falling is this one:

if (typeof version.updateTime !== 'undefined') {
            if (!validator.isISODateString(version.updateTime) &&
                !validator.isUTCDateString(version.updateTime)) {
                throw new remote_config_api_client_internal_1.FirebaseRemoteConfigError('invalid-argument', 'Version update time must be a valid date string');
            }
            if (validator.isISODateString(version.updateTime)) {
                // timestamps in output `Version` obtained from the API should be in UTC.
                this.updateTime = new Date(version.updateTime).toUTCString();
            }
        }

The isISODateString fails with 6 but works with 3 milliseconds places. No idea how that happened, any suggestions on how to fix this is appreciated.

lahirumaramba · 2020-11-13T19:03:42Z

Thank you for reporting this issue!
We are currently working on a fix and this issue will track the progress. Thank you for your patience!

moshaheen · 2020-11-13T19:25:57Z

The issue is happening because of isISODateString check
This should be a high priority ticket as it is breaking all code the depends on firebase remoteConfig

moshaheen · 2020-11-13T19:27:56Z

I noticed that the problem seems to be related to the number of places used for the milliseconds
This is the version time that is being returned for me 2020-11-13T18:30:14.543720Z, for a valid ISO it should be just 3 instead of 6 before the Z, so 2020-11-13T18:30:14.543Z

The code falling is this one:
if (typeof version.updateTime !== 'undefined') {
            if (!validator.isISODateString(version.updateTime) &&
                !validator.isUTCDateString(version.updateTime)) {
                throw new remote_config_api_client_internal_1.FirebaseRemoteConfigError('invalid-argument', 'Version update time must be a valid date string');
            }
            if (validator.isISODateString(version.updateTime)) {
                // timestamps in output `Version` obtained from the API should be in UTC.
                this.updateTime = new Date(version.updateTime).toUTCString();
            }
        }
The isISODateString fails with 6 but works with 3 milliseconds places. No idea how that happened, any suggestions on how to fix this is appreciated.

Yes, that is exactly the case.

ryanoboril · 2020-11-13T22:11:15Z

I very much appreciate how quickly this was fixed! You developers are amazing ❤️

I see that the fix was merged, are you going to publish a new release of the firebase-admin npm? The latest is still 9.4.0, and this issue was closed.

hiranya911 · 2020-11-13T22:14:24Z

I see that the fix was merged, are you going to publish a new release of the firebase-admin npm? The latest is still 9.4.0, and this issue was closed.

Yes, it's on the way. We are also following up with the backend team to figure out why the date format changed suddenly (and will continue to do so after the release too).

ryanoboril · 2020-11-13T22:15:23Z

Thank you so much. You all rock! 👍

Contains a fix for #1088

lahirumaramba · 2020-11-13T22:58:54Z

Thank you everyone for your patience! We have included the fix in 9.4.1.
We will continue to investigate the cause with the backend teams and will take measures to prevent any similar breaking changes in the future.

ajayagrawal · 2020-11-30T10:35:07Z

I am still facing this issue.

[email protected]

errorInfo:
{ code: 'remote-config/invalid-argument',
message: 'Version update time must be a valid date string' },
codePrefix: 'remote-config' }

lahirumaramba · 2020-11-30T17:56:03Z

I am still facing this issue.

[email protected]

errorInfo:
{ code: 'remote-config/invalid-argument',
message: 'Version update time must be a valid date string' },
codePrefix: 'remote-config' }

@ajayagrawal Thank you for letting us know. The initial issue should now be fixed in v9.4.1. If you are still seeing this issue, could you please provide us with more details? Do you see the above error when performing a specific operation?

DavidMGini · 2020-12-01T14:27:28Z

Hi. I appreciate how fast this was solved.
Yet, I am facing the same issue.
I don't know how to upgrade to v9.4.1
Guess I have to, right now, otherwise my work is blocked.

lahirumaramba · 2020-12-01T20:14:16Z

@DavidMGini Unfortunately, you have to update firebase-admin to v9.4.1 to fix the issue. Start with a npm update firebase-admin@latest. Please let us know if you still see the error after updating. Thanks!

DavidMGini · 2020-12-01T21:35:58Z

Updated - error went away immediately.
Much appreciated. :)

ajayagrawal · 2020-12-02T09:47:12Z

@lahirumaramba I am using the remote config fetch function as mention here:https://firebase.google.com/docs/remote-config/automate-rc and getting this error.
I have updated my firebase-admin as per your suggestion.

The complete error is as below:
Unable toget template { Error: Version update time must be a valid date string at FirebaseRemoteConfigError.FirebaseError [as constructor] (~mobile/iOS/backend/firebase_function/master_latest/functions/node_modules/firebase-admin/lib/utils/error.js:42:28) at FirebaseRemoteConfigError.PrefixedFirebaseError [as constructor] (~mobile/iOS/backend/firebase_function/master_latest/functions/node_modules/firebase-admin/lib/utils/error.js:88:28) at new FirebaseRemoteConfigError (~mobile/iOS/backend/firebase_function/master_latest/functions/node_modules/firebase-admin/lib/remote-config/remote-config-utils.js:43:23) at new VersionImpl (~mobile/iOS/backend/firebase_function/master_latest/functions/node_modules/firebase-admin/lib/remote-config/remote-config.js:287:23) at new RemoteConfigTemplateImpl (~mobile/iOS/backend/firebase_function/master_latest/functions/node_modules/firebase-admin/lib/remote-config/remote-config.js:198:28) at ~mobile/iOS/backend/firebase_function/master_latest/functions/node_modules/firebase-admin/lib/remote-config/remote-config.js:60:20 at process._tickCallback (internal/process/next_tick.js:68:7) errorInfo: { code: 'remote-config/invalid-argument', message: 'Version update time must be a valid date string' }, codePrefix: 'remote-config' }

lahirumaramba · 2020-12-02T23:01:54Z

@ajayagrawal Your node_modules could still be pointing to an older version of firebase-admin. Please try cleaning up the node_modules directory. You can also remove the package-lock.json and run npm install. Please note that this will reinstall all your dependencies so if you were using any specific versions of other dependencies in your project confirm them after the process is complete.

ajayagrawal · 2020-12-03T14:50:42Z

@lahirumaramba now it's working thanks for the help.

Contains a fix for firebase#1088

google-oss-bot added the needs-triage label Nov 13, 2020

lahirumaramba self-assigned this Nov 13, 2020

lahirumaramba added api: remoteconfig and removed needs-triage labels Nov 13, 2020

ryanoboril pushed a commit to ryanoboril/firebase-admin-node that referenced this issue Nov 13, 2020

fix(validator): handle 6-digit millis iso date string (firebase#1088)

975c566

lahirumaramba mentioned this issue Nov 13, 2020

fix(rc): Fix Version update time parsing failure #1089

Merged

lahirumaramba closed this as completed in #1089 Nov 13, 2020

hiranya911 mentioned this issue Nov 13, 2020

[chore] Release 9.4.1 #1091

Merged

lahirumaramba added a commit that referenced this issue Nov 13, 2020

[chore] Release 9.4.1 (#1091)

0d72380

Contains a fix for #1088

hiranya911 assigned erikeldridge Nov 13, 2020

BorntraegerMarc pushed a commit to BorntraegerMarc/firebase-admin-node that referenced this issue Jan 28, 2021

[chore] Release 9.4.1 (firebase#1091)

9dd3287

Contains a fix for firebase#1088

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

firebase remote config get template api fails throws "Version update time must be a valid date string" #1088

firebase remote config get template api fails throws "Version update time must be a valid date string" #1088

arshedg commented Nov 13, 2020

google-oss-bot commented Nov 13, 2020

sulayyudiz commented Nov 13, 2020

whereissami commented Nov 13, 2020

evilass commented Nov 13, 2020

fkneist commented Nov 13, 2020

WiNloSt commented Nov 13, 2020

VGJohn commented Nov 13, 2020

ryanoboril commented Nov 13, 2020

lukencrocker commented Nov 13, 2020

moshaheen commented Nov 13, 2020

pedr0ni commented Nov 13, 2020 •

edited

Loading

leonardoj-cit commented Nov 13, 2020 •

edited

Loading

lahirumaramba commented Nov 13, 2020

moshaheen commented Nov 13, 2020 •

edited

Loading

moshaheen commented Nov 13, 2020

ryanoboril commented Nov 13, 2020

hiranya911 commented Nov 13, 2020

ryanoboril commented Nov 13, 2020

lahirumaramba commented Nov 13, 2020

ajayagrawal commented Nov 30, 2020

lahirumaramba commented Nov 30, 2020

DavidMGini commented Dec 1, 2020

lahirumaramba commented Dec 1, 2020

DavidMGini commented Dec 1, 2020

ajayagrawal commented Dec 2, 2020 •

edited

Loading

lahirumaramba commented Dec 2, 2020

ajayagrawal commented Dec 3, 2020

firebase remote config get template api fails throws "Version update time must be a valid date string" #1088

firebase remote config get template api fails throws "Version update time must be a valid date string" #1088

Comments

arshedg commented Nov 13, 2020

Issue is reproducible in Firebase cloud function and in the local cloud function simulator(started occurring from 13-nov-2020)

Firebase node admin api "admin.remoteConfig().getTemplate() or config.getTemplateAtVersion" throws error

Steps to reproduce:

additional information

google-oss-bot commented Nov 13, 2020

sulayyudiz commented Nov 13, 2020

whereissami commented Nov 13, 2020

evilass commented Nov 13, 2020

fkneist commented Nov 13, 2020

WiNloSt commented Nov 13, 2020

VGJohn commented Nov 13, 2020

ryanoboril commented Nov 13, 2020

lukencrocker commented Nov 13, 2020

moshaheen commented Nov 13, 2020

pedr0ni commented Nov 13, 2020 • edited Loading

leonardoj-cit commented Nov 13, 2020 • edited Loading

lahirumaramba commented Nov 13, 2020

moshaheen commented Nov 13, 2020 • edited Loading

moshaheen commented Nov 13, 2020

ryanoboril commented Nov 13, 2020

hiranya911 commented Nov 13, 2020

ryanoboril commented Nov 13, 2020

lahirumaramba commented Nov 13, 2020

ajayagrawal commented Nov 30, 2020

lahirumaramba commented Nov 30, 2020

DavidMGini commented Dec 1, 2020

lahirumaramba commented Dec 1, 2020

DavidMGini commented Dec 1, 2020

ajayagrawal commented Dec 2, 2020 • edited Loading

lahirumaramba commented Dec 2, 2020

ajayagrawal commented Dec 3, 2020

pedr0ni commented Nov 13, 2020 •

edited

Loading

leonardoj-cit commented Nov 13, 2020 •

edited

Loading

moshaheen commented Nov 13, 2020 •

edited

Loading

ajayagrawal commented Dec 2, 2020 •

edited

Loading