Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yarn dependency duplication. #908

Merged
merged 1 commit into from
Feb 8, 2020
Merged

Remove yarn dependency duplication. #908

merged 1 commit into from
Feb 8, 2020

Conversation

texodus
Copy link
Member

@texodus texodus commented Feb 6, 2020

Cleans up duplicate yarn.lock entries by tightening some dependency ranges, as discussed in #906

@sebinsua
Copy link
Contributor

sebinsua commented Feb 6, 2020

Btw there is a useful package to get visibility of this kind of thing and which can automate fixing it. Maybe you've used it before - just mentioning it because it's a lot easier than needing to do this manually.

@texodus texodus force-pushed the yarn-dedupe branch 2 times, most recently from ad86ccb to 2103737 Compare February 8, 2020 14:19
@texodus
Copy link
Member Author

texodus commented Feb 8, 2020

Thanks @sebinsua ! The key thing missing here was a node.js version constraint to our dev dependencies, as emscripten and our Docker runtimes are somewhat inflexibly tied to 8.x

@texodus texodus merged commit c17a289 into master Feb 8, 2020
@texodus texodus deleted the yarn-dedupe branch February 8, 2020 16:39
@texodus texodus added internal Internal refactoring and code quality improvement JS labels Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants