Bump core-js to v3.6.4 and Babel to 7.8.4 #906
Conversation
We should upgrade core-js@2 to core-js@3 because the (1) the next major release of Babel will do so, and (2) there are many V8 de-optimizations in core-js@2 that have been fixed in core-js@3. See: babel/babel#10746 (comment) See: babel/babel#10746 (comment) See: https://github.com/zloirock/core-js/blob/master/docs/2019-03-19-core-js-3-babel-and-a-look-into-the-future.md We also bumped Babel to 7.8.4 because it was only after 7.4 that core-js@3 was supported. See: https://babeljs.io/blog/2019/03/19/7.4.0#core-js-3-7646-https-githubcom-babel-babel-pull-7646
|
@texodus It seems to pass the tests.
|
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/finos/perspective" | ||
| }, |
There was a problem hiding this comment.
Something weird about this diff since this is not where this property is within the current package.json.
|
@sebinsua Thanks for the PR! I made a
|
|
Another view of this change via the upcoming |
There was a problem hiding this comment.
Looks good!
I noticed some irregularities in yarn.lock such duplicate @babel/core that traced back to the complete other end of the project as well ... so I will follow this up with a few tweaks to package.json to tighten these resolutions.
We should upgrade
core-js@2tocore-js@3because the (1) the next major release of Babel will do so, and (2) there are many V8 de-optimizations incore-js@2that have been fixed incore-js@3.Note: Half-expecting there to be some kind of build issue, so opening a PR to see what's what.