Remove python 2 from build and CI scripts #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't care about python 2 anymore, and [I was repeatedly assured time and time again that nobody else would after December 2020](https://www.efinancialcareers.com/news/2021/02/jpmorgan-still-has-its-python-2-issue) 😉 🇬🇷 🦉
|
Perspective hasn't supported Python2 for a long time #1336, no assurances necessary, even from an esteemed pillar of technology journalism like ... (checks notes) ... efinancialcareers.com. I would like to keep https://github.com/finos/perspective/pull/1583/files#diff-7915b9b726a397ae7ba6af7b9703633d21c031ebf21682f3ee7e6a4ec52837a5L356 though, but a working version that does not cause weekly all-in CI builds to fail. |
re-added, should be fine with #1563 |
timkpaine
changed the title
timkpaine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't care about python 2 anymore, and I was assured that nobody else would after December 2020 😉 🇬🇷 🦉