Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate py27 (linux), add py39 (osx) #1336

Merged
merged 3 commits into from
Apr 2, 2021
Merged

Deprecate py27 (linux), add py39 (osx) #1336

merged 3 commits into from
Apr 2, 2021

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Feb 26, 2021

Fixes #1334, adds py39 now that brew defaults this on OSX.

@timkpaine timkpaine added enhancement Feature requests or improvements Python WIP labels Feb 26, 2021
@timkpaine
Copy link
Member Author

builds all passing except the 2 that require docker changes, so looks good

@timkpaine timkpaine requested a review from sc1f February 26, 2021 17:15
Copy link
Contributor

@sc1f sc1f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - will need a rebuild of the Docker images, and a full tagged build run to check if the wheel builds work.

Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dockerfile modifications in this file do not build - it appears as if the method on step 42 for acquiring nodejs via yum has bit-rotted, which I recognize was not touched by this PR, but nonetheless ...

The experience of discovering this after >1hr of docker build, suggests strongly to me we need a better method of building Python, perhaps we build these images exclusively from Azure? Are these images needed still now that the pyarrow dependency has been removed?

Regardless, two things are true, (1) I cannot merge this PR until the Dockerfile builds, and (2) addressing this tech debt must pre-empt any future image dists.

@timkpaine
Copy link
Member Author

I've updated and tested building the docker images from scratch. They are necessary as azure does not provide a manylinux compatible environment, so in order to dist linux wheels we need these docker images.

@timkpaine
Copy link
Member Author

(I've also dropped python2 in these last changes)

@texodus
Copy link
Member

texodus commented Apr 2, 2021

(I've also dropped python2 in these last changes)

Nice try - I've refactored these changes to #1374

@texodus texodus linked an issue Apr 2, 2021 that may be closed by this pull request
@texodus texodus added this to the 0.7.0 milestone Apr 2, 2021
@texodus texodus changed the title fixes #1334, adds py39 now that brew defaults this on osx Add py39 on OSX Apr 2, 2021
@texodus texodus removed the WIP label Apr 2, 2021
@texodus
Copy link
Member

texodus commented Apr 2, 2021

Upon further review, the pypa/manylinux2010_x86_64 container we relied upon is now non-reproducible, as the upper-bound of python2 compatible versions is above the lower-bound of CentOS 6 compatible versions. This makes python2 effectively deprecated, even if this image was preserved.

Which means that 0.6.2 is the last python2 "compatible" version that will be published - insofar as perspective-python can be compatible with a language whose own support has been deprecated.

@texodus texodus changed the title Add py39 on OSX Deprecate py27 (linux), add py39 (osx) Apr 2, 2021
@texodus texodus merged commit 28eddda into master Apr 2, 2021
@texodus texodus deleted the py3638build branch April 2, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python wheel builds failing on catalina for py36 and py38
3 participants