free() pointer to arrow binary in Python #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkpaine
reviewed
Jan 5, 2021
| @@ -193,6 +194,10 @@ std::shared_ptr<Table> make_table_py(t_val table, t_data_accessor accessor, | |||
| _fill_data(data_table, accessor, input_schema, index, offset, limit, is_update); | |||
| } | |||
|
|
|||
| if (is_arrow) { | |||
There was a problem hiding this comment.
is there any case where is_arrow && is_delete?
There was a problem hiding this comment.
e.g. should this match above if (is_arrow && !is_delete) {
There was a problem hiding this comment.
There shouldn't be any - remove only takes a list of pkeys, but this whole conditional block is kind of messy. I'll take a look and fix.
There was a problem hiding this comment.
This logic is incorrect, but so is the fix suggestion - there should be (or will need to be) one case, for remove() ... when we get around to fixing this API method generally ...
texodus
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small issue in Perspective's arrow loading code in Python - previously, the pointer to the malloc'd section for the arrow binary was never explicitly free'd (as it was in Javascript). This leads to the memory allocated for the binary leaking after the arrow is loaded into Perspective.
With testing using
psutiland 25 updates usingsuperstore.arrow, comparing memory usage with/without free() shows a significant impact:Without free():
rss: 115539968 bytesrss: 302710784 bytesWith free():
rss: 113532928 bytesrss: 245538816 bytesMemory usage grows much more slowly when
free()is added, demonstrating the leak.