-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): set CODECOV_TOKEN after action upgrade #442
Conversation
- codecov-action@v4 requires the token to be set - flags are not necessary at this time. its used to differentiate test types and/or sub-components in a monorepo. For now, we just want to see all test coverage across the whole project.
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
@JamieSlome before we merge, let me try modifying our "skip on empty coverage step", validating that Codecov gets the full report then I'll revert the change. |
- this commit will be reverted; DO NOT MERGE
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
===========================================
- Coverage 73.58% 56.85% -16.74%
===========================================
Files 1 39 +38
Lines 53 1036 +983
===========================================
+ Hits 39 589 +550
- Misses 14 447 +433
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nyc.config.js wasn't working as intended. I'm going to permanently remove this logic since it just produces the following error:
@JamieSlome codecov handles the difference in changed files already and I think some of the numbers coming back from the tool are misreported because we were monkeying around with the files to include into nyc's report generation. If we run with the full report and use codecov instead to report the differences in changed files, I do not believe we need our own logic to do this. The token change is sound and confirmed in the workflow that reports are being posted again. I'll need to merge this into main to generate a baseline, then rebase on my other branch on #415 to get accurate coverage differences. |
- remove the parsing of changed files for PRs via nyc.config.js - add codecov.yml and set reports to informational only (dont block PRs) - add codecov badge to README
5d623a5
to
18c12f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
Fixes #441