Skip to content

Commit

Permalink
Merge pull request #442 from RBC/hotfix/codecov-token
Browse files Browse the repository at this point in the history
  • Loading branch information
coopernetes authored Feb 8, 2024
2 parents c43b5de + 18c12f0 commit dbcd124
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 47 deletions.
15 changes: 1 addition & 14 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,24 +45,11 @@ jobs:
run: |
npm run test-coverage-ci || echo "Silently ignoring coverage threshold limit..."
- name: Check if a valid lcov.info file is generated
id: check-lcov-non-empty
run: |
if [ -s "./coverage/lcov.info" ]; then
echo "lcov.info is not empty."
echo "isNotEmpty=true" >> $GITHUB_OUTPUT
else
echo "lcov.info is empty."
echo "isNotEmpty=false" >> $GITHUB_OUTPUT
fi
- name: Upload test coverage report
if: ${{ steps.check-lcov-non-empty.outputs.isNotEmpty == 'true'}}
uses: codecov/[email protected]
with:
files: ./coverage/lcov.info
flags: unittests
token: ${{ secrets.CODECOV_TOKEN }}
# - name: Exit if coverage condition not met
# if: ${{ steps.test.outputs.exit_code }} != 0
# run: exit ${{ steps.test.outputs.exit_code }}

1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
[![FINOS - Incubating](https://cdn.jsdelivr.net/gh/finos/contrib-toolbox@master/images/badge-incubating.svg)](https://community.finos.org/docs/governance/Software-Projects/stages/incubating)
[![NPM](https://img.shields.io/npm/v/@finos/git-proxy?colorA=00C586&colorB=000000)](https://www.npmjs.com/package/@finos/git-proxy)
[![Build](https://img.shields.io/github/actions/workflow/status/finos/git-proxy/nodejs.yml?branch=main&label=CI&logo=github&colorA=00C586&colorB=000000)](https://github.com/finos/git-proxy/actions/workflows/nodejs.yml)
[![codecov](https://codecov.io/gh/finos/git-proxy/branch/main/graph/badge.svg)](https://codecov.io/gh/finos/git-proxy)
[![Documentation](https://img.shields.io/badge/_-documentation-000000?colorA=00C586&logo=docusaurus&logoColor=FFFFFF&)](https://git-proxy.finos.org)
<br />
[![License](https://img.shields.io/github/license/finos/git-proxy?colorA=00C586&colorB=000000)](https://github.com/finos/git-proxy/blob/main/LICENSE)
Expand Down
8 changes: 8 additions & 0 deletions codecov.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
coverage:
status:
project:
default:
informational: true
patch:
default:
informational: true
34 changes: 1 addition & 33 deletions nyc.config.js
Original file line number Diff line number Diff line change
@@ -1,41 +1,9 @@
/* eslint-disable max-len */
'use strict';

const { execFileSync } = require('child_process');

let opts = {
const opts = {
branches: 80,
lines: 80,
functions: 80,
statements: 80,
};

// Only generate coverage report for changed files in PR
// see: https://github.com/actions/checkout/issues/438#issuecomment-1446882066
// https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables
if (process.env.GITHUB_BASE_REF !== undefined) {
console.log('Generating coverage report for changed files...');
try {
const baseRef = execFileSync('git', [
'rev-parse',
`origin/${process.env.GITHUB_BASE_REF}`,
])
.toString()
.replace('\n', '');
const headRef = process.env.GITHUB_SHA;
const stdout = execFileSync('git', [
'diff',
'--name-only',
`${baseRef}..${headRef}`,
]).toString();
opts = {
...opts,
include: stdout.split('\n'),
};
} catch (error) {
console.log('Error: ', error);
}
}

console.log('nyc config: ', opts);
module.exports = opts;

0 comments on commit dbcd124

Please sign in to comment.