Externalize babel helpers using @babel/runtime

[petermikitsh]

tl,dr:

This reduces the ES module size from 27545 to 26852 bytes (~2.5%) by externalizing babel runtime helper functions.

Many people are using these helper functions elsewhere. By externalizing them, folks can take advantage of only including a single copy (as opposed to the additional copy that was inlined by react-final-form).

It appears this was the original intent of the repository since @babel/runtime is already a production dependency.

Details

react-final-form.es.js goes from something like this:

import { createElement, Component, createContext } from 'react';
import { fieldSubscriptionItems, configOptions, createForm, formSubscriptionItems, version } from 'final-form';

function _extends() {
  _extends = Object.assign || function (target) {
    for (var i = 1; i < arguments.length; i++) {
      var source = arguments[i];

      for (var key in source) {
        if (Object.prototype.hasOwnProperty.call(source, key)) {
          target[key] = source[key];
        }
      }
    }

    return target;
  };

  return _extends.apply(this, arguments);
}

// Other babel helper functions (not shown).

to this:

import _extends from '@babel/runtime/helpers/extends';
import _objectWithoutPropertiesLoose from '@babel/runtime/helpers/objectWithoutPropertiesLoose';
import _inheritsLoose from '@babel/runtime/helpers/inheritsLoose';
import { createElement, Component, createContext } from 'react';
import { fieldSubscriptionItems, configOptions, createForm, formSubscriptionItems, version } from 'final-form';

//      
function diffSubscription (a, b, keys) {
  if (a) {
    if (b) {
      // $FlowFixMe
      return keys.some(function (key) {
        return a[key] !== b[key];
      });
    } else {
      return true;
    }
  } else {
    return !!b;
  }
}

Related

final-form/react-final-form-arrays#60

[codecov]

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #402   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         207    207           
  Branches       61     61           
=====================================
  Hits          207    207

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f655e7...8cfc0cd. Read the comment docs.

[Andarist]

Yeah, that was the intention implemented in #351 . However seems that I've screwed it up in #366 .

[Andarist]

could you remove it from .babelrc.js and add it like this: https://github.com/final-form/react-final-form/pull/351/files#diff-ff6e5f22a9c7e66987b19c0199636480R86 ?

[petermikitsh]

@Andarist Fixed ✅

[Andarist]

@erikras friendly 🏓

[petermikitsh]

Fixed merge conflict, all checks pass

[erikras]

Published in v4.1.0

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.