Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @babel/runtime helpers instead of bundled ones #351

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

Andarist
Copy link
Contributor

Focus of this PR is to use @babel/runtime helpers instead of including their copy in distributed sources.

Motivation
Shipping less code - by using @babel/runtime helpers we are able to deduplicate their code across all dependencies using them.

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #351 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #351   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         205    205           
  Branches       61     61           
=====================================
  Hits          205    205

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce9c2b9...d827304. Read the comment docs.

@erikras
Copy link
Member

erikras commented Oct 17, 2018

This destroys my "ZERO DEPENDENCIES!!!" claim, though, does it not?

@Andarist
Copy link
Contributor Author

It depends on how do you look at it :P you already depend on this code, you just bundle it into your library instead of using external package 😉

@Andarist
Copy link
Contributor Author

thoughts on this one? 😉

@erikras erikras merged commit 1e4d1f4 into final-form:master Nov 15, 2018
@erikras
Copy link
Member

erikras commented Nov 15, 2018

Published in v3.7.0.

@lock
Copy link

lock bot commented Dec 15, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 15, 2018
@Andarist Andarist deleted the use-runtime-helpers branch December 15, 2018 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants