Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't dump object internals #404

Merged
merged 3 commits into from
Apr 5, 2016
Merged

Conversation

jonasdt
Copy link
Contributor

@jonasdt jonasdt commented Mar 20, 2016

This improves #402 as follows:

  • Only dump object internals if a custom caster exists. This allows integrations with frameworks to define custom casters. E.g. for Laravel we can dump the attributes of an Eloquent model.
  • Don't dump verbose information (e.g. exception stack traces).

@rossbearman
Copy link

This change makes a dramatic speed improvement, from around one minute to under a second, assuming this doesn't cause any issues it would be great to see this pulled into the core.

@denis-sokolov denis-sokolov merged commit afab26b into filp:master Apr 5, 2016
@denis-sokolov
Copy link
Collaborator

Thank you, @jonasdt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants