dump function arguments with PrettyPageHandler

[Druid33]

Hi, i use PrettyPageHandler to display errors in my application. I think, its awesome library.

In stacktrace, bellow code i expected function arguments to be displayed. Its ok for primitive types. But for objects Whoops display only type of object instead of expandable dump of variable.

What i see:

What i expected:

I dig into tho code and find, that if i comment adding Casters to Cloner in PrettyPageHnadler->__construct() method, i get output i expected.

whoops/src/Whoops/Handler/PrettyPageHandler.php

Line 145 in cde50e6

$cloner->addCasters(['*' => function ($obj, $a, $stub, $isNested, $filter = 0) {

Its a future or its a bug? :)

[denis-sokolov]

It does, indeed, look like a bug. Thank you for reporting this!

Somebody will take a look at it and hopefully we’ll get it fixed properly.

[denis-sokolov]

I’ve now found out this is on purpose, as dumping everything indiscriminately did not allow us to maintain the level of performance we expect. See #401 and #404!

Thanks for bringing it up, if anyone comes up with an improvement, let us know.

[Druid33]

Hi, again.

First sorry for reopening ticket.

I use PrettyPageHandler with commented line i mention in ticket description for 5 months without performance issues. I know...its only my case.

The problem is, that i cant extend PrettyPageHandler and use my own cloner instance, because cloner is set in constructor. So i copy-paste that class and make lot of dirty changes to make it run.

Now, i start new project, i like to have function arguments dumped, but i dont wont make dirty copy-paste "solution" again.

It will be fine have chance make it clean. Is it possible to make simple protected setCloner() method on PrettyPageHandler?

protected setCloner($cloner) 
{
    $this->templateHelper->setCloner($cloner);
}

I thing thats enough for everyone, who can dump funcion argument in PrettyPageHandler.

[Druid33]

..or just make $templateHelper property protected instead of private.

/**
* @var TemplateHelper
*/
protected $templateHelper;