Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed crash that could occur when dragging in grouped grid layout #14654

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

hishitetsu
Copy link
Member

Since it is difficult to directly fix the crash, scrolling is disabled while dragging as a workaround.

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: File drag and drop crash in Grid Layout #14484

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Change the layout to Grid.
    2. Change the group option to other than None.
    3. Drag an item to the bottom of the window.
    4. No longer crashes.

@hishitetsu hishitetsu marked this pull request as draft February 6, 2024 13:52
@hishitetsu hishitetsu marked this pull request as ready for review February 6, 2024 14:02
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's interesting that this doesn't affect Details but either way, this workaround looks good.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 6, 2024
@yaira2 yaira2 merged commit a06aafc into files-community:main Feb 6, 2024
6 checks passed
@hishitetsu hishitetsu deleted the DisableDragAndDropScroll branch February 7, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: File drag and drop crash in Grid Layout
2 participants